{Containerapp} Use get_mgmt_service_client to create ServiceLinkerManagementClient
#30799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiasli
requested review from
Greedygre,
Juliehzl and
howang-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
jiasli
commented
Feb 10, 2025
| resource = cmd.cli_ctx.cloud.endpoints.active_directory_resource_id | ||
| profile = Profile(cli_ctx=cmd.cli_ctx) | ||
| credential, subscription_id, _ = profile.get_login_credentials( | ||
| subscription_id=get_subscription_id(cmd.cli_ctx), resource=resource) |
Member
Author
There was a problem hiding this comment.
resource will be dropped by Track 1 SDK authentication removal (#29631).
get_mgmt_service_client takes care of passing credential_scopes.
microsoft-github-policy-service
bot
requested review from
JennyLawrance,
chinadragon0515,
ebencarek,
jijohn14,
jsntcy,
pagariyaalok,
ruslany,
sanchitmehta,
torosent,
vinisoto,
vturecek,
wangzelin007,
yanzhudd,
yonzhan and
zhoxing-ms
evelyn-ys
approved these changes
Feb 12, 2025
zhoxing-ms
approved these changes
Feb 12, 2025
jiasli
commented
Feb 12, 2025
| linker_client = ServiceLinkerManagementClient(credential) | ||
| return linker_client | ||
| from azure.cli.core.commands.client_factory import get_mgmt_service_client | ||
| return get_mgmt_service_client(cmd.cli_ctx, ServiceLinkerManagementClient) |
Member
Author
There was a problem hiding this comment.
The logic of get_subscription_id is already covered by get_mgmt_service_client.
CustardTart32
pushed a commit
to CustardTart32/azure-cli
that referenced
this pull request
Feb 27, 2025
…ManagementClient` (Azure#30799)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
Mgmt-plane SDK client should be created by
get_mgmt_service_client, not manually created.