Skip to content

{Containerapp} Use get_mgmt_service_client to create ServiceLinkerManagementClient #30799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiasli merged 1 commit into from
Feb 12, 2025
Merged

{Containerapp} Use get_mgmt_service_client to create ServiceLinkerManagementClient #30799

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/azure-cli/azure/cli/command_modules/containerapp/_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,12 +412,8 @@ def parse_secret_flags(secret_list):


def get_linker_client(cmd):
resource = cmd.cli_ctx.cloud.endpoints.active_directory_resource_id
profile = Profile(cli_ctx=cmd.cli_ctx)
credential, subscription_id, _ = profile.get_login_credentials(
subscription_id=get_subscription_id(cmd.cli_ctx), resource=resource)
Copy link
Member Author

@jiasli jiasli Feb 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resource will be dropped by Track 1 SDK authentication removal (#29631).

get_mgmt_service_client takes care of passing credential_scopes.

linker_client = ServiceLinkerManagementClient(credential)
return linker_client
from azure.cli.core.commands.client_factory import get_mgmt_service_client
return get_mgmt_service_client(cmd.cli_ctx, ServiceLinkerManagementClient)
Copy link
Member Author

@jiasli jiasli Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic of get_subscription_id is already covered by get_mgmt_service_client.



def validate_binding_name(binding_name):
Expand Down