[compute] Proximity placement group support #9154
Conversation
adewaleo
force-pushed
the
proximity-placement-groups
branch
2 times, most recently
from
93ea962 to
57993c2
Compare
There was a problem hiding this comment.
Is this a correct trace message when the PPD is not available?
There was a problem hiding this comment.
This is just for debugging purpose to show what was processed for the parameter. I can reword the logging message.
There was a problem hiding this comment.
what will happen at service end, if we don't do the check at client end? Do we get a good error?
There was a problem hiding this comment.
I believe the error should be something like the following, if the ppg is in a different region or does not exist:
Deployment failed. Correlation ID: 260fc599-b6f4-418f-9c2e-fc800602d78f. {
"error": {
"code": "NotFound",
"message": "Proximity Placement Group '/subscriptions/00977cdb-163f-435f-9c32-39ec8ae61f4d/resourceGroups/ova-test/providers/Microsoft.Compute/proximityPlacementGroups/tosinppg' cannot be found."
}
}
The CLI does perform this check for availability set... in _validate_vm_create_availability_set. I can remove both existence checks or keep both.-
There was a problem hiding this comment.
you might need to update other command modules such as acs
There was a problem hiding this comment.
Yes @yugangw-msft acs and servicefabric have been updated.
There was a problem hiding this comment.
This should be proximity placement group not availability set
There was a problem hiding this comment.
debug statement just in case the user enters an invalid proximity placement group. The previous lines try to parse the resource if and return None. Maybe I should actually raise a CLI error if this fails to parse...
What do you think?
There was a problem hiding this comment.
maybe DiskStorageAccountTypes = DiskStorageAccountTypes or StorageAccountTypes
adewaleo
force-pushed
the
proximity-placement-groups
branch
2 times, most recently
from
f80194b to
c983709
Compare
…lability-set create
…vailability-set create. Ensure validator logic is correct.
…hotStorageAccountTypes instead of hardcoded accounttype list.
update history.rst
adewaleo
force-pushed
the
proximity-placement-groups
branch
from
c983709 to
3a39379
Compare
3 participants
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.