-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[compute] Proximity placement group support #9154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
28ca182
Start PPG work. Add ppg command group.
0597c0e
PPG Command group essentially complete. Need to support --ids and add…
26c4511
Add --proximity-placement group to vm create, vmss create and vm avai…
3d8bbe4
Add proximity placement groups to template logic in vm, vmss and vm a…
8d590d2
Renamed --proximity-placement-group to --ppg. Added --tags. Added tests.
30b4e46
Move to compute 4.6.2
6aafe47
Remove private whl file.
e247b6f
Improve debug and error message.
941c6fa
Bump up versions to draft SDK. Test draft SDK.
c2e2b9e
Use DiskStorageAccountTypes instead of StorageAccountTypes. Use Snaps…
05ef7d6
clean up validate_proximity_placement_group. Remove privates whl file.
b04c49e
Style fixes.
3a39379
Image create exposes --hyper-v-generation and defaults to V1.
4967292
Re-record failed vm tests after rebasing.
0ea11bc
Work around resource group scrubbing bug.
6b250a9
Minor linter fixes. Add # endregion comment.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Move to compute 4.6.2
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you might need to update other command modules such as acs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes @yugangw-msft acs and servicefabric have been updated.