-
Notifications
You must be signed in to change notification settings - Fork 525
Change Feed: Fixes incorrect exception messages in VersionedAndRidCheckedCompositeToken #4580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ealsur
merged 2 commits into
Azure:master
from
ThePartyPinguin:fix-versioned-and-rid-checked-composite-token-exceptions
Jul 8, 2024
Merged
Change Feed: Fixes incorrect exception messages in VersionedAndRidCheckedCompositeToken #4580
ealsur
merged 2 commits into
Azure:master
from
ThePartyPinguin:fix-versioned-and-rid-checked-composite-token-exceptions
Jul 8, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ealsur
approved these changes
Jul 8, 2024
Member
ealsur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for being proactive and avoiding others to stumble on the same problem
Contributor
Author
|
@ealsur No problem, happy to help |
kirankumarkolli
approved these changes
Jul 8, 2024
This was referenced Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
During my own development I got confused due some incorrect exception message in the VersionedAndRidCheckedCompositeToken struct.
This PR fixes the exception messages to use the correct expected data type.
It also fixes an incorrect reference to the 'Version' property name in where 'Rid' should be references
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber