Skip to content

Change Feed: Fixes incorrect exception messages in VersionedAndRidCheckedCompositeToken - #4580

Merged
ealsur merged 2 commits into
Azure:masterfrom
ThePartyPinguin:fix-versioned-and-rid-checked-composite-token-exceptions
Jul 8, 2024
Merged

Change Feed: Fixes incorrect exception messages in VersionedAndRidCheckedCompositeToken#4580
ealsur merged 2 commits into
Azure:masterfrom
ThePartyPinguin:fix-versioned-and-rid-checked-composite-token-exceptions

Conversation

@ThePartyPinguin

Copy link
Copy Markdown
Contributor

Pull Request Template

Description

During my own development I got confused due some incorrect exception message in the VersionedAndRidCheckedCompositeToken struct.

This PR fixes the exception messages to use the correct expected data type.
It also fixes an incorrect reference to the 'Version' property name in where 'Rid' should be references

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)

Closing issues

To automatically close an issue: closes #IssueNumber

@ealsur

ealsur commented Jul 8, 2024

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@ealsur ealsur changed the title Fixes incorrect exception messages in VersionedAndRidCheckedCompositeToken Change Feed: Fixes incorrect exception messages in VersionedAndRidCheckedCompositeToken Jul 8, 2024
@ealsur
ealsur enabled auto-merge (squash) July 8, 2024 16:44
@ealsur ealsur added the auto-merge Enables automation to merge PRs label Jul 8, 2024
@ealsur

ealsur commented Jul 8, 2024

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@ealsur ealsur left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for being proactive and avoiding others to stumble on the same problem

@ThePartyPinguin

Copy link
Copy Markdown
Contributor Author

@ealsur No problem, happy to help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge Enables automation to merge PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants