Skip to content

Change Feed: Fixes incorrect exception messages in VersionedAndRidCheckedCompositeToken #4580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ealsur merged 2 commits into from
Jul 8, 2024
Merged

Change Feed: Fixes incorrect exception messages in VersionedAndRidCheckedCompositeToken #4580

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a27ad1
Fixes incorrect exception message and property name reference
ThePartyPinguin Jul 8, 2024
7f4e18b
Merge branch 'master' into fix-versioned-and-rid-checked-composite-to…
ealsur Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Microsoft.Azure.Cosmos/src/FeedRange/VersionedAndRidCheckedCompositeToken.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,13 +60,13 @@ public static TryCatch<VersionedAndRidCheckedCompositeToken> MonadicCreateFromCo
if (!cosmosObject.TryGetValue(PropertyNames.Continuation, out CosmosElement continuationValue))
{
return TryCatch<VersionedAndRidCheckedCompositeToken>.FromException(
new FormatException($"expected number {nameof(PropertyNames.Continuation)} property for {nameof(VersionedAndRidCheckedCompositeToken)}: {cosmosElement}."));
new FormatException($"expected object {nameof(PropertyNames.Continuation)} property for {nameof(VersionedAndRidCheckedCompositeToken)}: {cosmosElement}."));
}

if (!cosmosObject.TryGetValue(PropertyNames.Rid, out CosmosString ridValue))
{
return TryCatch<VersionedAndRidCheckedCompositeToken>.FromException(
new FormatException($"expected number {nameof(PropertyNames.Version)} property for {nameof(VersionedAndRidCheckedCompositeToken)}: {cosmosElement}."));
new FormatException($"expected string {nameof(PropertyNames.Rid)} property for {nameof(VersionedAndRidCheckedCompositeToken)}: {cosmosElement}."));
}

VersionedAndRidCheckedCompositeToken token = new VersionedAndRidCheckedCompositeToken(
Expand Down