HttpTimeoutPolicy Improvements Phase 3: Fixes the TimeoutPolicies to Have Segregated Timeouts for Point-Reads and Non-Point-Reads with Uniform Timeouts #5497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananth7592
previously approved these changes
Nov 14, 2025
…he configurable timeouts.
Microsoft.Azure.Cosmos/src/HttpClient/HttpTimeoutPolicyForPartitionFailover.cs
Show resolved
Hide resolved
…ient http policy.
Praveen-Msft
changed the title
Microsoft.Azure.Cosmos/src/HttpClient/HttpTimeoutPolicyForThinClient.cs
Outdated
Show resolved
Hide resolved
kirankumarkolli
previously approved these changes
Nov 14, 2025
| (TimeSpan.FromSeconds(1), TimeSpan.Zero), | ||
| (TimeSpan.FromSeconds(6), TimeSpan.Zero), | ||
| (TimeSpan.FromSeconds(6), TimeSpan.Zero), | ||
| (TimeSpan.FromSeconds(10), TimeSpan.Zero), |
Member
There was a problem hiding this comment.
Please update PR description with more context (based on our conversation)
kirankumarkolli
approved these changes
Nov 14, 2025
aavasthy
approved these changes
Nov 14, 2025
kundadebdatta
changed the title
kundadebdatta
requested review from
FabianMeiswinkel,
Pilchie,
adityasa,
khdang,
kirillg,
neildsh and
sboshra
as code owners
kundadebdatta
approved these changes
Nov 14, 2025
Member
kundadebdatta
left a comment
kundadebdatta
left a comment
There was a problem hiding this comment.
LGTM: Let's wait for the detailed PR description before merging this into master.
Member
|
#auto-merge |
kirankumarkolli
deleted the
users/pkolluri/5496-configurable-timeouts
branch
This was referenced Nov 29, 2025
Merged
This was referenced Dec 6, 2025
This was referenced Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
At a high-level, this PR aims to unify the timeouts across PPAF and thin client http retry policies for read only requests. Furthermore, HttpTimeoutPolicies for PPAF and Thinclient will have segregated timeouts for Point-Reads and Non-Point-Reads. With this change, we will have the ability to fine-tune/optimize the timeouts for the respective operations. In this context, requests are allowed to retry 3 times with 6s, 6s and 10s timeouts respectively for each retry. We chose these timeouts based on the default backend response timeouts and it will help requests being timeout with aggressive timeouts.
As next step, we have planned for DR drill to identify the appropriate timeouts. Depending on the findings from the drill, we may go towards the direction of configurable timeout for first retry.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #5496