-
Notifications
You must be signed in to change notification settings - Fork 525
HttpTimeoutPolicy Improvements Phase 3: Fixes the TimeoutPolicies to Have Segregated Timeouts for Point-Reads and Non-Point-Reads with Uniform Timeouts #5497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kirankumarkolli
merged 4 commits into
master
from
users/pkolluri/5496-configurable-timeouts
Nov 14, 2025
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
751bef5
PPAF: Fixes http first retry timeout value to be configurable for poi…
Praveen-Msft d35b0b9
Keep same timeouts for PPAF point reads and non-point reads, remove t…
Praveen-Msft 12fdc13
Separate the timeouts for point reads and non-point-reads for thin-cl…
Praveen-Msft 06b7153
Update the instance name to InstanceShouldNotRetryAndThrow503OnTimeou…
Praveen-Msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,13 +20,13 @@ private HttpTimeoutPolicyForPartitionFailover(bool isPointRead) | |
| } | ||
|
|
||
| // Timeouts and delays are based on the following rationale: | ||
| // For point reads: 3 attempts with timeouts of 1s, 6s, and 6s respectively. | ||
| // For point reads: 3 attempts with timeouts of 6s, 6s, and 10s respectively. | ||
| // For non-point reads: 3 attempts with timeouts of 6s, 6s, and 10s respectively. | ||
| private readonly IReadOnlyList<(TimeSpan requestTimeout, TimeSpan delayForNextRequest)> TimeoutsAndDelaysForPointReads = new List<(TimeSpan requestTimeout, TimeSpan delayForNextRequest)>() | ||
| { | ||
| (TimeSpan.FromSeconds(1), TimeSpan.Zero), | ||
| (TimeSpan.FromSeconds(6), TimeSpan.Zero), | ||
| (TimeSpan.FromSeconds(6), TimeSpan.Zero), | ||
| (TimeSpan.FromSeconds(10), TimeSpan.Zero), | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please update PR description with more context (based on our conversation) |
||
| }; | ||
|
|
||
| private readonly IReadOnlyList<(TimeSpan requestTimeout, TimeSpan delayForNextRequest)> TimeoutsAndDelaysForNonPointReads = new List<(TimeSpan requestTimeout, TimeSpan delayForNextRequest)>() | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.