-
Notifications
You must be signed in to change notification settings - Fork 200
Worker Extension project incremental build support #1749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liliankasem
reviewed
Aug 14, 2023
liliankasem
approved these changes
Aug 14, 2023
# Conflicts: # sdk/Sdk/Sdk.csproj
Contributor
Author
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
This was referenced Aug 23, 2023
jviau
added a commit
that referenced
this pull request
Jan 18, 2024
…d nuget feed issues (#1946) * Worker Extension project incremental build support (#1749) * Merge main to feature/ext-proj (#1832) * Refactor SDK targets to address multiple writes and flaky builds (#1861) * Ensure ExtensionsCsProjDirectory is a full path (#1938) * Pass RestoreSources to inner-build restore task (#1937) * Rev SDK version to 1.16.0-preview1 (#1941) * Skip func targets during design time build (#1954) * Correct merge mistakes * Update sln * Fix properties * update worker.config.json generation (#2122) * [SDK] Remove properties from inner-build (#2161) * Expand on RemoveProperties for inner build. Fix source gen default * Add PublishProfile to remove props * Un-remove some properties from inner build
This was referenced Oct 20, 2025
This was referenced Nov 10, 2025
This was referenced Dec 2, 2025
Open
Bump Azure.Identity and Microsoft.Azure.Functions.Worker.ApplicationInsights
louisledev/photosync#20
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #1740
This PR attempts to solve frequent pain points with our SDK build steps which cause file locked issues. I believe the issue lies with how we perform an inner-build with the
WorkerExtensions.csprojto generate collect host extensions. To mitigate this inner-build causing file lock issues, two primary changes have been made:WorkerExtension.csprojis now generated & built in the intermediate output path of the outer-project (typicallyobj/{Configuration}/{TargetFramework}) under theWorkerExtensionsfolder.Directory.Build.propsandDirectory.Build.targetsis disabled for the inner-build, to avoid unintentional consequences of moving to intermediate output path.SkipUnchangedto avoid copying files which already exist and are up to date at the target destinationThese changes combined reduces how much happens on re-builds of a functions worker project, which as a result means less file interactions and thus less file locked issues.
I believe there is still one file-locked issue we will be unable to resolve without help from the NuGet team. Our inner-build restore is not part of the outer-build restore. Instead, it happens as part of the
AfterBuildstage of the outer-build. I have seen instances of files in the NuGet package cache being locked at this point in time, causing build issues. Unfortunately, this is out of our control and can only be addressed by participating in the outer-build restore.Pull request checklist
TODO
release_notes.md