[SDK] Remove properties from inner-build #2161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
7 tasks
|
Looking for a work around for a production deployment that is required. |
Contributor
Author
|
@codeputer please use issues to discuss those types of requests |
kshyju
approved these changes
Dec 20, 2023
jviau
added a commit
that referenced
this pull request
Jan 18, 2024
…d nuget feed issues (#1946) * Worker Extension project incremental build support (#1749) * Merge main to feature/ext-proj (#1832) * Refactor SDK targets to address multiple writes and flaky builds (#1861) * Ensure ExtensionsCsProjDirectory is a full path (#1938) * Pass RestoreSources to inner-build restore task (#1937) * Rev SDK version to 1.16.0-preview1 (#1941) * Skip func targets during design time build (#1954) * Correct merge mistakes * Update sln * Fix properties * update worker.config.json generation (#2122) * [SDK] Remove properties from inner-build (#2161) * Expand on RemoveProperties for inner build. Fix source gen default * Add PublishProfile to remove props * Un-remove some properties from inner build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #1995, #1798
Pull request checklist
release_notes.mdAdditional information
This PR removes several properties from the inner builds to address an issue that can arise from publishing via Visual Studio. Specifically, Visual Studio will supply many parameters from the active publish profile as global parameters. These will flow to the inner
WorkerExtension.csprojand adversely impacting how it restores and builds. This can manifest as assembly load issues that don't appear when running locally, but only when publishing to Azure from VS.