Skip to content
This repository was archived by the owner on Oct 12, 2023. It is now read-only.

Conversation

@yugangw-msft
Copy link
Contributor

This header contains tokens used to access resource from other tenants for scenarios like 'vnet peering', 'vm image sharing'

//cc: @troydai

@codecov-io
Copy link

codecov-io commented May 23, 2018

Codecov Report

Merging #46 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #46   +/-   ##
====================================
  Coverage      50%   50%           
====================================
  Files          10    10           
  Lines         438   438           
  Branches       72    72           
====================================
  Hits          219   219           
  Misses        213   213           
  Partials        6     6
Impacted Files Coverage Δ
src/azure_devtools/scenario_tests/base.py 37.9% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29150dc...0d3fb0b. Read the comment docs.

@troydai
Copy link
Contributor

troydai commented May 24, 2018

Two questions:

  1. Will this break existing recordings? (I don't think so.)
  2. Can you update the setup.py so we can create a new release. This can fit into a patch update as long as no tests are broken ( -> 1.0.1)

@yugangw-msft
Copy link
Contributor Author

@troydai, it will not break any existing recordings, this header is optional, and rarely used

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants