Servicebus: updated for GEO DR #1714
Conversation
ravbhatnagar
left a comment
ravbhatnagar
left a comment
There was a problem hiding this comment.
@v-Ajnava - Some feedback for you
| } | ||
| ], | ||
| "responses": { | ||
| "201": { |
There was a problem hiding this comment.
Please use 202 for delete LRO.
There was a problem hiding this comment.
Reverted as delete is not async
| "properties": { | ||
| "x-ms-client-flatten": true, | ||
| "properties": { | ||
| "provisioningState": { |
There was a problem hiding this comment.
Resolved, we don't support cancel.
| } | ||
| } | ||
| }, | ||
| "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceBus/namespaces/{namespaceName}/disasterRecoveryConfig/{alias}/breakpairing": { |
There was a problem hiding this comment.
breakPairing (camelcase)
| } | ||
| } | ||
| }, | ||
| "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ServiceBus/namespaces/{namespaceName}/disasterRecoveryConfig": { |
There was a problem hiding this comment.
pluralize resource type name? disasterRecoveryConfigs.
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: 💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡 AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
|
@sarangan12 can you add your feedback here |
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: 💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡 AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
|
No modification for AutorestCI/azure-sdk-for-node |
8 participants
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger