Skip to content

Servicebus: Geo DR feature #3750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shahabhijeet merged 7 commits into from
Oct 5, 2017
Merged

Servicebus: Geo DR feature #3750

shahabhijeet merged 7 commits into from
Oct 5, 2017

Conversation

@v-Ajnava
Copy link

@v-Ajnava v-Ajnava commented Sep 27, 2017 •
edited
Loading

Description

Geo DR feature added

This change adds metadata Geo-Disaster recovery support to the Service Bus .NET management client. API are being added to create and manage a Disaster recovery configuration which allows users to pair two Service Bus namespaces in a primary-secondary configuration and creates an alias to represent the DR pair. Also, being added are APIs to trigger a Geo-DR failover which re-points the alias from the primary to the secondary namespace and APIs to break DR pairing which disables Geo-DR.

Swagger change PR Link : Azure/azure-rest-api-specs#1714

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

sphibbs
sphibbs reviewed Sep 28, 2017
View reviewed changes
Copy link
Contributor

@sphibbs sphibbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are there 3 deleted tests. looks like this PR is additive functionality.

@v-Ajnava
Copy link
Author

v-Ajnava commented Sep 28, 2017

@sphibbs, Those tests were to check the removal of maximum length constrain for Subscription and Authorizationrules. Removal of Max length constrain change was only for top level entities like Queues and Topics and reverted for Subscription and Authorizationrules. So deleted those tests.

shahabhijeet
shahabhijeet suggested changes Sep 29, 2017
View reviewed changes
Copy link
Contributor

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing proper description for the PR.
Looking at the PR, there is no way to know what is being changed. Please be very clear as to what changes are going in. This is a public repo and contributors everywhere should know what is being checked in.
Please provide link to the swagger change PR (not the commit but the PR)
Also missing the metadata file.
Missing version bump for the SDK

src/SDKs/ServiceBus/ServiceBus.Tests/ServiceBus.Tests.csproj Outdated
<TargetFrameworks>netcoreapp1.1</TargetFrameworks>
</PropertyGroup>

<ItemGroup>
Copy link
Contributor

@shahabhijeet shahabhijeet Sep 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Including ItemGroup for files is not necessary.
Please remove this ItemGroup as the new project system picks up all files

Copy link
Author

@v-Ajnava v-Ajnava Oct 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

@v-Ajnava
Copy link
Author

v-Ajnava commented Oct 3, 2017

@shahabhijeet, Swagger change PR Link : Azure/azure-rest-api-specs#1714

@v-Ajnava
Copy link
Author

v-Ajnava commented Oct 3, 2017

@cormacpayne, have updated the PR description, version and metadata file, please let me know your comments.

@v-Ajnava
Copy link
Author

v-Ajnava commented Oct 4, 2017

@shahabhijeet, I am not able to change the label and have addressed all the comments.

shahabhijeet
shahabhijeet suggested changes Oct 5, 2017
View reviewed changes
Copy link
Contributor

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add release notes to EvenHub as well, similar to what is mentioned in this PR.

src/SDKs/ServiceBus/Management.ServiceBus/Microsoft.Azure.Management.ServiceBus.csproj
<PackageTags>Microsoft Azure ServiceBus Management;ServiceBus;ServiceBus management</PackageTags>
<TargetFrameworks>net452;netstandard1.4</TargetFrameworks>
<VersionPrefix>1.0.1</VersionPrefix>
<VersionPrefix>1.0.2</VersionPrefix>
Copy link
Contributor

@shahabhijeet shahabhijeet Oct 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add < PackageReleaseNotes > and add Release notes.
I would recommend to use < ![CDATA and then format your Release notes

https://github.com/Azure/azure-sdk-for-net/blob/psSdkJson6/src/SDKs/MarketplaceOrdering/Management.MarketplaceOrdering/Microsoft.Azure.Management.MarketplaceOrdering.csproj#L10

Copy link
Author

@v-Ajnava v-Ajnava Oct 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated package release notes

Copy link
Author

@v-Ajnava v-Ajnava Oct 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shahabhijeet, have updated package release notes. can you please review it.

@shahabhijeet shahabhijeet merged commit a5317bd into Azure:psSdkJson6 Oct 5, 2017
EvgenyAgafonchikov pushed a commit to EvgenyAgafonchikov/azure-sdk-for-net that referenced this pull request Oct 13, 2017
@EvgenyAgafonchikov
Servicebus: Geo DR feature (Azure#3750)
0c6e31c 
* Geo DR changes

* Geo DR Tests

* Latest swagger code

* Removed the Length tests for subscription and authorizationrules as this is reverted.

* updated PR description, version and metadata file.

* updated PackageReleaseNotes
JasonYang-MSFT pushed a commit to JasonYang-MSFT/azure-sdk-for-net that referenced this pull request Dec 8, 2017
@JasonYang-MSFT
Servicebus: Geo DR feature (Azure#3750)
afb45b0 
* Geo DR changes

* Geo DR Tests

* Latest swagger code

* Removed the Length tests for subscription and authorizationrules as this is reverted.

* updated PR description, version and metadata file.

* updated PackageReleaseNotes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@sphibbs sphibbs sphibbs left review comments

@shahabhijeet shahabhijeet shahabhijeet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@v-Ajnava @sphibbs @shahabhijeet