Skip to content

Add built in policy definition/set definition paths #1788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
veronicagg merged 10 commits into from
Oct 4, 2017
Merged

Add built in policy definition/set definition paths #1788

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
503e9fe
Add built in policy definitions paths
vivsriaus Oct 3, 2017
3abdae4
Merge
vivsriaus Oct 3, 2017
4288c9c
Add built in policy definitions paths
vivsriaus Oct 3, 2017
a0a081a
Remove unnecessary subId parameter from MG paths
vivsriaus Oct 3, 2017
5da03ba
Remove unnecessary subId parameter from MG paths
vivsriaus Oct 3, 2017
91c7775
404 is valid response, remove filter parameter from list operations
vivsriaus Oct 3, 2017
26ebb96
Add support for getting/listing buil in policy set definitions
vivsriaus Oct 3, 2017
75b1c0c
Remove x-ms-odata for list policy definitions and set definitions
vivsriaus Oct 3, 2017
cf054dd
Add 404 response to example to get the CI model validation job to pass
vivsriaus Oct 4, 2017
730e2ee
Camel case policyDefinitions and policySetDefinitions in paths
vivsriaus Oct 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add built in policy definitions paths
  • Loading branch information
@vivsriaus
vivsriaus committed Oct 3, 2017
commit 4288c9c52b462ac0b9d334472b44467dcd55ea9b
62 changes: 62 additions & 0 deletions ...tion/resources/resource-manager/Microsoft.Authorization/2016-12-01/policyDefinitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,35 @@
}
}
},
"/providers/Microsoft.Authorization/policydefinitions/{policyDefinitionName}": {
Copy link
Contributor

@veronicagg veronicagg Oct 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this api missing from the spec? or is it newly added to the existing api version?

Copy link
Contributor Author

@vivsriaus vivsriaus Oct 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was missing from the spec

Copy link
Contributor

@ravbhatnagar ravbhatnagar Oct 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

camel case ->policyDefinitions

"get": {
"tags": [
"PolicyDefinitions"
],
"operationId": "PolicyDefinitions_GetBuiltIn",
"description": "Gets the built in policy definition.",
"parameters": [
{
"name": "policyDefinitionName",
"in": "path",
"required": true,
"type": "string",
"description": "The name of the built in policy definition to get."
},
{
"$ref": "#/parameters/ApiVersionParameter"
}
],
"responses": {
"200": {
Copy link
Contributor

@pilor pilor Oct 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

404 should be valid response correct?

Copy link
Contributor Author

@vivsriaus vivsriaus Oct 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

"description": "OK - Returns information about the built in policy definition.",
"schema": {
"$ref": "#/definitions/PolicyDefinition"
}
}
}
}
},
"/providers/Microsoft.Management/managementgroups/{managementGroupId}/providers/Microsoft.Authorization/policydefinitions/{policyDefinitionName}": {
"put": {
"tags": [
Expand Down Expand Up @@ -283,6 +312,39 @@
"x-ms-odata": "#/definitions/PolicyDefinition"
}
},
"/providers/Microsoft.Authorization/policydefinitions": {
Copy link
Contributor

@veronicagg veronicagg Oct 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this api missing from the spec before but existed in the service?

Copy link
Contributor Author

@vivsriaus vivsriaus Oct 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we never added this to spec

"get": {
"tags": [
"PolicyDefinitions"
],
"operationId": "PolicyDefinitions_ListBuiltIn",
"description": "Gets all the built in policy definitions.",
"parameters": [
{
"name": "$filter",
Copy link
Contributor

@pilor pilor Oct 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

policyDefinition collection requests don't support odata fliters. Only policyAssignments have filters

Copy link
Contributor Author

@vivsriaus vivsriaus Oct 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

"in": "query",
"required": false,
"type": "string",
"description": "The filter to apply on the operation."
},
{
"$ref": "#/parameters/ApiVersionParameter"
}
],
"responses": {
"200": {
"description": "OK - Returns ana array of built in policy definitions.",
Copy link
Contributor

@pilor pilor Oct 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Returns an"

Copy link
Contributor Author

@vivsriaus vivsriaus Oct 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

"schema": {
"$ref": "#/definitions/PolicyDefinitionListResult"
}
}
},
"x-ms-pageable": {
"nextLinkName": "nextLink"
},
"x-ms-odata": "#/definitions/PolicyDefinition"
}
},
"/providers/Microsoft.Management/managementgroups/{managementGroupId}/providers/Microsoft.Authorization/policydefinitions": {
"get": {
"tags": [
Expand Down