Skip to content

Add built in policy definition/set definition paths #1788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
veronicagg merged 10 commits into from
Oct 4, 2017
Merged

Add built in policy definition/set definition paths #1788

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
503e9fe
Add built in policy definitions paths
vivsriaus Oct 3, 2017
3abdae4
Merge
vivsriaus Oct 3, 2017
4288c9c
Add built in policy definitions paths
vivsriaus Oct 3, 2017
a0a081a
Remove unnecessary subId parameter from MG paths
vivsriaus Oct 3, 2017
5da03ba
Remove unnecessary subId parameter from MG paths
vivsriaus Oct 3, 2017
91c7775
404 is valid response, remove filter parameter from list operations
vivsriaus Oct 3, 2017
26ebb96
Add support for getting/listing buil in policy set definitions
vivsriaus Oct 3, 2017
75b1c0c
Remove x-ms-odata for list policy definitions and set definitions
vivsriaus Oct 3, 2017
cf054dd
Add 404 response to example to get the CI model validation job to pass
vivsriaus Oct 4, 2017
730e2ee
Camel case policyDefinitions and policySetDefinitions in paths
vivsriaus Oct 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
404 is valid response, remove filter parameter from list operations
  • Loading branch information
@vivsriaus
vivsriaus committed Oct 3, 2017
commit 91c7775cf119d7bb7cee3d5cbf0f4e640bf79680
26 changes: 4 additions & 22 deletions ...tion/resources/resource-manager/Microsoft.Authorization/2016-12-01/policyDefinitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,9 @@
"schema": {
"$ref": "#/definitions/PolicyDefinition"
}
},
"404": {
"description": "Not Found - the built in policy definition was not found."
}
}
}
Expand Down Expand Up @@ -275,13 +278,6 @@
"operationId": "PolicyDefinitions_List",
"description": "Gets all the policy definitions for a subscription.",
"parameters": [
{
"name": "$filter",
Copy link
Member

@lmazuel lmazuel Oct 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this was not supported and here by mistake?

Copy link
Contributor Author

@vivsriaus vivsriaus Oct 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, apparently, only policy assignment list supports filter. Not policy definitions and set definitions

Copy link
Member

@lmazuel lmazuel Oct 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, this was exposed in the CLI, I create an issue for that

Copy link
Member

@lmazuel lmazuel Oct 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Azure/azure-cli#4603

"in": "query",
"required": false,
"type": "string",
"description": "The filter to apply on the operation."
},
{
"$ref": "#/parameters/ApiVersionParameter"
},
Expand Down Expand Up @@ -311,20 +307,13 @@
"operationId": "PolicyDefinitions_ListBuiltIn",
"description": "Gets all the built in policy definitions.",
"parameters": [
{
"name": "$filter",
"in": "query",
"required": false,
"type": "string",
"description": "The filter to apply on the operation."
},
{
"$ref": "#/parameters/ApiVersionParameter"
}
],
"responses": {
"200": {
"description": "OK - Returns ana array of built in policy definitions.",
"description": "OK - Returns an array of built in policy definitions.",
"schema": {
"$ref": "#/definitions/PolicyDefinitionListResult"
}
Expand All @@ -344,13 +333,6 @@
"operationId": "PolicyDefinitions_ListByManagementGroup",
"description": "Gets all the policy definitions for a subscription at management group level.",
"parameters": [
{
"name": "$filter",
Copy link
Member

@lmazuel lmazuel Oct 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question, not supported?

Copy link
Contributor Author

@vivsriaus vivsriaus Oct 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, not supported

"in": "query",
"required": false,
"type": "string",
"description": "The filter to apply on the operation."
},
{
"$ref": "#/parameters/ApiVersionParameter"
},
Expand Down