Skip to content

Conversation

@Francisco-Gamino
Copy link
Contributor

@Francisco-Gamino Francisco-Gamino commented Dec 15, 2017

SourceControls is a resource to link an user source control with their Azure Automation (AA) account.

SourceControlSyncJob allows the user to sync their runbooks from their external source source control with their AA account.


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@Francisco-Gamino
Copy link
Contributor Author

@MiaRomero: Could you please follow-up with on this while I am on vacation? Thanks!

@Francisco-Gamino
Copy link
Contributor Author

Francisco-Gamino commented Dec 16, 2017

@vrdmr for FYI.

@vrdmr
Copy link
Member

vrdmr commented Dec 18, 2017

@MiaRomero @Francisco-Gamino - Hi, could you please fix the issues reported by the linter before you merge the changes - http://az-bot.azurewebsites.net/linter?fileName=2158_1513382035359.json

@marstr marstr changed the base branch from current to master December 28, 2017 17:54
@vrdmr
Copy link
Member

vrdmr commented Jan 2, 2018

@Francisco-Gamino @MiaRomero Could you please take a look at the Job and fix the building issues - https://travis-ci.org/Azure/azure-rest-api-specs/jobs/324210781

error:  Error: Unable to read the content or execute "JSON.parse()" on the content of file "specification/automation/resource-manager/Microsoft.Automation/2015-10-31/definitions.json". The error is:
Error: ENOENT: no such file or directory, open 'specification/automation/resource-manager/Microsoft.Automation/2015-10-31/definitions.json'
    at Object.parseJson (/home/travis/build/Azure/azure-rest-api-specs/node_modules/oav/lib/util/utils.js:79:15)
    at SpecResolver.resolveRelativeReference (/home/travis/build/Azure/azure-rest-api-specs/node_modules/oav/lib/validators/specResolver.js:263:18)
    at /home/travis/build/Azure/azure-rest-api-specs/node_modules/oav/lib/validators/specResolver.js:210:40
    at <anonymous>

@fearthecowboy
Copy link
Contributor

(FYI, pull from your branch, some reorganization of the repository happened over the break, and some files moved)

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/automation/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 59
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

zhedahht and others added 2 commits January 2, 2018 16:48
* Initial commit

Initial commit

* Changes for new API version 2017-12-01-preview

Changes for new API version 2017-12-01-preview

* ReadMe changes

ReadMe changes

* Swagger changes for ACI

Swagger changes for ACI

* More changes on ACI swagger spec

More changes on ACI swagger spec

* Remove secrets from the response

Remove secrets from the response
@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/automation/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 59
After the PR: Warning(s): 0 Error(s): 59

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@fearthecowboy
Copy link
Contributor

@Francisco-Gamino
Copy link
Contributor Author

Closing this PR as it is being replaced by #2219.

@AutorestCI
Copy link

Was unable to find SDK Azure/azure-sdk-for-python PR for this closed PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants