-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Add resources for SourceControl and SourceControlSyncJob #2219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
marstr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Howdy @MiaRomero,
Before we get started in earnest with the review of this PR, please take a look at the CI logs here:
https://travis-ci.org/Azure/azure-rest-api-specs/jobs/325642969#L734
I see in the PR Bot's comment above that you haven't added any new linter errors, but the model errors should be addressed if they are new because of your PR.
|
Feel free to reach out here, or offline, if you have questions about reading the CI output. :) |
|
Hi @marstr, Thank you for the CI logs. I have made changes to correct the errors, but before I push them, can you tell me how I can see the logs or find out if there are any more errors? I saw "All checks have passed" and thought that everything was ok. Where do I look to see if there are any errors created by my PR? Thanks! |
|
Ah yeah, sorry about that! I know it's a confusing thing, and something we're trying to improve on our side. If you click on "Show all checks" then "Details" for "continuous-integration/travis-ci/pr --- The Travis CI build passed" it'll bring you here. From there you'll see that there are two sections: "Build Jobs" and "Allowed Failures". All of the "Build Jobs" must pass, and any of the "Allowed Failures" that are marked as "PR_ONLY=true". You may very reasonably ask, "if there are things that are marked allowed failure, then why do I have to fix it?" Basically the answer is, for a handful of services we don't yet have all of their linter and model errors either fixed or suppressed. Until that time comes, we're stuck with this non-optimal solution. Sorry for the inconvenience! |
|
@marstr, Thank you very much! I"ll keep an eye on those when I push my changes. |
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
|
Looks good. |
|
Let me know when you're ready for this to merge, @MiaRomero. The only assurances that we need are that the service will be live and ready to start receiving requests matching these additions. |
|
Hi @marstr, you can go ahead and merge. Thank you! |
|
Was unable to find SDK Azure/azure-sdk-for-python PR for this closed PR. |
Replacement for PR #2158
SourceControl is a resource to link a user's source control with their Azure Automation (AA) account.
SourceControlSyncJob allows the user to sync their runbooks from their external source control with their AA account.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger