Skip to content

Conversation

@MiaRomero
Copy link
Contributor

@MiaRomero MiaRomero commented Jan 5, 2018

Replacement for PR #2158

SourceControl is a resource to link a user's source control with their Azure Automation (AA) account.

SourceControlSyncJob allows the user to sync their runbooks from their external source control with their AA account.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/automation/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 59
After the PR: Warning(s): 0 Error(s): 59

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

Copy link
Member

@marstr marstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Howdy @MiaRomero,

Before we get started in earnest with the review of this PR, please take a look at the CI logs here:
https://travis-ci.org/Azure/azure-rest-api-specs/jobs/325642969#L734

I see in the PR Bot's comment above that you haven't added any new linter errors, but the model errors should be addressed if they are new because of your PR.

@marstr
Copy link
Member

marstr commented Jan 9, 2018

Feel free to reach out here, or offline, if you have questions about reading the CI output. :)

@MiaRomero
Copy link
Contributor Author

Hi @marstr, Thank you for the CI logs. I have made changes to correct the errors, but before I push them, can you tell me how I can see the logs or find out if there are any more errors? I saw "All checks have passed" and thought that everything was ok. Where do I look to see if there are any errors created by my PR? Thanks!

@marstr
Copy link
Member

marstr commented Jan 10, 2018

Ah yeah, sorry about that! I know it's a confusing thing, and something we're trying to improve on our side.

If you click on "Show all checks" then "Details" for "continuous-integration/travis-ci/pr --- The Travis CI build passed" it'll bring you here. From there you'll see that there are two sections: "Build Jobs" and "Allowed Failures". All of the "Build Jobs" must pass, and any of the "Allowed Failures" that are marked as "PR_ONLY=true".

You may very reasonably ask, "if there are things that are marked allowed failure, then why do I have to fix it?" Basically the answer is, for a handful of services we don't yet have all of their linter and model errors either fixed or suppressed. Until that time comes, we're stuck with this non-optimal solution.

Sorry for the inconvenience!

@MiaRomero
Copy link
Contributor Author

@marstr, Thank you very much! I"ll keep an eye on those when I push my changes.

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/automation/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 59
After the PR: Warning(s): 0 Error(s): 59

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@marstr marstr added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 11, 2018
@ravbhatnagar
Copy link
Contributor

Looks good.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 18, 2018
@marstr
Copy link
Member

marstr commented Jan 18, 2018

Let me know when you're ready for this to merge, @MiaRomero. The only assurances that we need are that the service will be live and ready to start receiving requests matching these additions.

@MiaRomero
Copy link
Contributor Author

Hi @marstr, you can go ahead and merge. Thank you!

@marstr marstr merged commit b3b961c into Azure:master Jan 24, 2018
@AutorestCI
Copy link

Was unable to find SDK Azure/azure-sdk-for-python PR for this closed PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants