Add new source controls properties #23891

sanchitmehta · 2023-05-09T23:02:13Z

This PR Adds new properties for Source Controls APIs

openapi-workflow-bot · 2023-05-09T23:02:16Z

Hi, @sanchitmehta Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2023-05-09T23:02:17Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

compared swaggers (via Oad v0.10.4)]	new version	base version
SourceControls.json	2023-04-01-preview(280e9e9)	2022-10-01(main)
SourceControls.json	2023-04-01-preview(280e9e9)	2022-11-01-preview(main)

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.1)	new version	base version
package-preview-2023-04	package-preview-2023-04(280e9e9)	package-preview-2023-04(release-app-Microsoft.App-2023-04-01-preview)

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` ResourceNameRestriction	The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-04-01-preview/SourceControls.json#L36
`❌` ResourceNameRestriction	The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-04-01-preview/SourceControls.json#L85
`❌` ResourceNameRestriction	The resource name parameter 'sourceControlName' should be defined with a 'pattern' restriction. Location: Microsoft.App/preview/2023-04-01-preview/SourceControls.json#L85
`❌` ProvisioningStateSpecifiedForLROPut	200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.App/preview/2023-04-01-preview/SourceControls.json#L137
`❌` ProvisioningStateSpecifiedForLROPut	201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.App/preview/2023-04-01-preview/SourceControls.json#L137
`❌` PutResponseSchemaDescription	Description of 200 response code of a PUT operation MUST include term 'update'. Location: Microsoft.App/preview/2023-04-01-preview/SourceControls.json#L178
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/preview/2023-04-01-preview/SourceControls.json#L194
`❌` DeleteOperationAsyncResponseValidation	An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.App/preview/2023-04-01-preview/SourceControls.json#L205
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.App/preview/2023-04-01-preview/SourceControls.json#L241
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.App/preview/2023-04-01-preview/SourceControls.json#L250
⚠️ SummaryAndDescriptionMustNotBeSame	The summary and description values should not be same. Location: Microsoft.App/preview/2023-04-01-preview/SourceControls.json#L137
⚠️ XmsLongRunningOperationOptions	The x-ms-long-running-operation-options should be specified explicitly to indicate the type of response header to track the async operation. Location: Microsoft.App/preview/2023-04-01-preview/SourceControls.json#L137
⚠️ SummaryAndDescriptionMustNotBeSame	The summary and description values should not be same. Location: Microsoft.App/preview/2023-04-01-preview/SourceControls.json#L205
⚠️ XmsLongRunningOperationOptions	The x-ms-long-running-operation-options should be specified explicitly to indicate the type of response header to track the async operation. Location: Microsoft.App/preview/2023-04-01-preview/SourceControls.json#L205
⚠️ ProvisioningStateSpecifiedForLRODelete	200 response schema in long running DELETE operation is missing ProvisioningState property. A LRO DELETE operations 200 response schema must have ProvisioningState specified. Location: Microsoft.App/preview/2023-04-01-preview/SourceControls.json#L238

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-05-09T23:02:18Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️✔️azure-sdk-for-go - sdk/resourcemanager/appcontainers/armappcontainers - 2.0.0-beta.3

+	Enum `Category` has been removed
+	Enum `ManagedEnvironmentOutBoundType` has been removed
+	Enum `SKUName` has been removed
+	Field `BillingMeterCategory` of struct `AvailableWorkloadProfileProperties` has been removed
+	Field `OutboundSettings`, `RuntimeSubnetID` of struct `VnetConfiguration` has been removed
+	Field `SKU` of struct `ManagedEnvironment` has been removed
+	Field `WorkloadProfileType` of struct `ContainerAppProperties` has been removed
+	Struct `EnvironmentSKUProperties` has been removed
+	Struct `ManagedEnvironmentOutboundSettings` has been removed
+	Type of `BillingMeterProperties.Category` has been changed from `*Category` to `*string`
+	Type of `CustomDomainConfiguration.CertificatePassword` has been changed from `[]byte` to `*string`
+	Type of `DaprSecretsCollection.Value` has been changed from `[]*Secret` to `[]*DaprSecret`

️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-appcontainers - Approved - 2.0.0

+	Model AvailableWorkloadProfileProperties no longer has parameter billing_meter_category
+	Model ContainerApp no longer has parameter workload_profile_type
+	Model ManagedEnvironment no longer has parameter sku
+	Model VnetConfiguration no longer has parameter outbound_settings
+	Model VnetConfiguration no longer has parameter runtime_subnet_id
+	Model WorkloadProfile has a new required parameter name

️✔️azure-sdk-for-js - @azure/arm-appcontainers - 2.0.0-beta.3

+	Interface ContainerAppsRevisionsListRevisionsNextOptionalParams no longer has parameter filter
+	Interface VnetConfiguration no longer has parameter runtimeSubnetId
+	Type of parameter customDomainVerificationFailureInfo of interface CustomHostnameAnalysisResult is changed from DefaultErrorResponse to CustomHostnameAnalysisResultCustomDomainVerificationFailureInfo
+	Type of parameter value of interface DaprSecretsCollection is changed from Secret[] to DaprSecret[]

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from 4ff68ad199a247c0167768186894bec1f1edd241. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.6
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.6>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-appcontainers [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation ContainerAppsOperations.begin_start
info	[Changelog]   - Added operation ContainerAppsOperations.begin_stop
info	[Changelog]   - Added operation group JobsExecutionsOperations
info	[Changelog]   - Added operation group JobsOperations
info	[Changelog]   - Added operation group ManagedCertificatesOperations
info	[Changelog]   - Model AvailableWorkloadProfileProperties has a new parameter category
info	[Changelog]   - Model AzureCredentials has a new parameter kind
info	[Changelog]   - Model ContainerApp has a new parameter managed_by
info	[Changelog]   - Model ContainerApp has a new parameter workload_profile_name
info	[Changelog]   - Model ContainerAppSecret has a new parameter identity
info	[Changelog]   - Model ContainerAppSecret has a new parameter key_vault_url
info	[Changelog]   - Model GithubActionConfiguration has a new parameter github_personal_access_token
info	[Changelog]   - Model Ingress has a new parameter sticky_sessions
info	[Changelog]   - Model ManagedEnvironment has a new parameter dapr_configuration
info	[Changelog]   - Model ManagedEnvironment has a new parameter infrastructure_resource_group
info	[Changelog]   - Model ManagedEnvironment has a new parameter keda_configuration
info	[Changelog]   - Model ManagedEnvironment has a new parameter peer_authentication
info	[Changelog]   - Model Replica has a new parameter init_containers
info	[Changelog]   - Model Replica has a new parameter running_state
info	[Changelog]   - Model Replica has a new parameter running_state_details
info	[Changelog]   - Model ReplicaContainer has a new parameter running_state
info	[Changelog]   - Model ReplicaContainer has a new parameter running_state_details
info	[Changelog]   - Model Revision has a new parameter running_state
info	[Changelog]   - Model Secret has a new parameter identity
info	[Changelog]   - Model Secret has a new parameter key_vault_url
info	[Changelog]   - Model Template has a new parameter termination_grace_period_seconds
info	[Changelog]   - Model Volume has a new parameter mount_options
info	[Changelog]   - Model Volume has a new parameter secrets
info	[Changelog]   - Model VolumeMount has a new parameter sub_path
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Model AvailableWorkloadProfileProperties no longer has parameter billing_meter_category
info	[Changelog]   - Model ContainerApp no longer has parameter workload_profile_type
info	[Changelog]   - Model ManagedEnvironment no longer has parameter sku
info	[Changelog]   - Model VnetConfiguration no longer has parameter outbound_settings
info	[Changelog]   - Model VnetConfiguration no longer has parameter runtime_subnet_id
info	[Changelog]   - Model WorkloadProfile has a new required parameter name

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from 4ff68ad199a247c0167768186894bec1f1edd241. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-appcontainers [View full logs] [Preview SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 4ff68ad199a247c0167768186894bec1f1edd241. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/appcontainers/armappcontainers [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `BillingMeterProperties.Category` has been changed from `*Category` to `*string`
info	[Changelog] - Type of `CustomDomainConfiguration.CertificatePassword` has been changed from `[]byte` to `*string`
info	[Changelog] - Type of `DaprSecretsCollection.Value` has been changed from `[]*Secret` to `[]*DaprSecret`
info	[Changelog] - Enum `Category` has been removed
info	[Changelog] - Enum `ManagedEnvironmentOutBoundType` has been removed
info	[Changelog] - Enum `SKUName` has been removed
info	[Changelog] - Struct `EnvironmentSKUProperties` has been removed
info	[Changelog] - Struct `ManagedEnvironmentOutboundSettings` has been removed
info	[Changelog] - Field `BillingMeterCategory` of struct `AvailableWorkloadProfileProperties` has been removed
info	[Changelog] - Field `WorkloadProfileType` of struct `ContainerAppProperties` has been removed
info	[Changelog] - Field `SKU` of struct `ManagedEnvironment` has been removed
info	[Changelog] - Field `OutboundSettings`, `RuntimeSubnetID` of struct `VnetConfiguration` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `StorageTypeSecret` added to enum type `StorageType`
info	[Changelog] - New enum type `Affinity` with values `AffinityNone`, `AffinitySticky`
info	[Changelog] - New enum type `ContainerAppContainerRunningState` with values `ContainerAppContainerRunningStateRunning`, `ContainerAppContainerRunningStateTerminated`, `ContainerAppContainerRunningStateWaiting`
info	[Changelog] - New enum type `ContainerAppReplicaRunningState` with values `ContainerAppReplicaRunningStateNotRunning`, `ContainerAppReplicaRunningStateRunning`, `ContainerAppReplicaRunningStateUnknown`
info	[Changelog] - New enum type `IngressClientCertificateMode` with values `IngressClientCertificateModeAccept`, `IngressClientCertificateModeIgnore`, `IngressClientCertificateModeRequire`
info	[Changelog] - New enum type `JobExecutionRunningState` with values `JobExecutionRunningStateDegraded`, `JobExecutionRunningStateFailed`, `JobExecutionRunningStateProcessing`, `JobExecutionRunningStateRunning`, `JobExecutionRunningStateStopped`, `JobExecutionRunningStateSucceeded`, `JobExecutionRunningStateUnknown`
info	[Changelog] - New enum type `JobProvisioningState` with values `JobProvisioningStateCanceled`, `JobProvisioningStateDeleting`, `JobProvisioningStateFailed`, `JobProvisioningStateInProgress`, `JobProvisioningStateSucceeded`
info	[Changelog] - New enum type `ManagedCertificateDomainControlValidation` with values `ManagedCertificateDomainControlValidationCNAME`, `ManagedCertificateDomainControlValidationHTTP`, `ManagedCertificateDomainControlValidationTXT`
info	[Changelog] - New enum type `RevisionRunningState` with values `RevisionRunningStateDegraded`, `RevisionRunningStateFailed`, `RevisionRunningStateProcessing`, `RevisionRunningStateRunning`, `RevisionRunningStateStopped`, `RevisionRunningStateUnknown`
info	[Changelog] - New enum type `TriggerType` with values `TriggerTypeEvent`, `TriggerTypeManual`, `TriggerTypeScheduled`
info	[Changelog] - New function `*ClientFactory.NewJobsClient() *JobsClient`
info	[Changelog] - New function `*ClientFactory.NewJobsExecutionsClient() *JobsExecutionsClient`
info	[Changelog] - New function `*ClientFactory.NewManagedCertificatesClient() *ManagedCertificatesClient`
info	[Changelog] - New function `*ContainerAppsClient.BeginStart(context.Context, string, string, *ContainerAppsClientBeginStartOptions) (*runtime.Poller[ContainerAppsClientStartResponse], error)`
info	[Changelog] - New function `*ContainerAppsClient.BeginStop(context.Context, string, string, *ContainerAppsClientBeginStopOptions) (*runtime.Poller[ContainerAppsClientStopResponse], error)`
info	[Changelog] - New function `NewJobsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*JobsClient, error)`
info	[Changelog] - New function `*JobsClient.BeginCreateOrUpdate(context.Context, string, string, Job, *JobsClientBeginCreateOrUpdateOptions) (*runtime.Poller[JobsClientCreateOrUpdateResponse], error)`
info	[Changelog] - New function `*JobsClient.BeginDelete(context.Context, string, string, *JobsClientBeginDeleteOptions) (*runtime.Poller[JobsClientDeleteResponse], error)`
info	[Changelog] - New function `*JobsClient.Get(context.Context, string, string, *JobsClientGetOptions) (JobsClientGetResponse, error)`
info	[Changelog] - New function `*JobsClient.NewListByResourceGroupPager(string, *JobsClientListByResourceGroupOptions) *runtime.Pager[JobsClientListByResourceGroupResponse]`
info	[Changelog] - New function `*JobsClient.NewListBySubscriptionPager(*JobsClientListBySubscriptionOptions) *runtime.Pager[JobsClientListBySubscriptionResponse]`
info	[Changelog] - New function `*JobsClient.ListSecrets(context.Context, string, string, *JobsClientListSecretsOptions) (JobsClientListSecretsResponse, error)`
info	[Changelog] - New function `*JobsClient.BeginStart(context.Context, string, string, JobExecutionTemplate, *JobsClientBeginStartOptions) (*runtime.Poller[JobsClientStartResponse], error)`
info	[Changelog] - New function `*JobsClient.BeginStopExecution(context.Context, string, string, string, *JobsClientBeginStopExecutionOptions) (*runtime.Poller[JobsClientStopExecutionResponse], error)`
info	[Changelog] - New function `*JobsClient.BeginStopMultipleExecutions(context.Context, string, string, JobExecutionNamesCollection, *JobsClientBeginStopMultipleExecutionsOptions) (*runtime.Poller[JobsClientStopMultipleExecutionsResponse], error)`
info	[Changelog] - New function `*JobsClient.BeginUpdate(context.Context, string, string, JobPatchProperties, *JobsClientBeginUpdateOptions) (*runtime.Poller[JobsClientUpdateResponse], error)`
info	[Changelog] - New function `NewJobsExecutionsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*JobsExecutionsClient, error)`
info	[Changelog] - New function `*JobsExecutionsClient.NewListPager(string, string, *JobsExecutionsClientListOptions) *runtime.Pager[JobsExecutionsClientListResponse]`
info	[Changelog] - New function `NewManagedCertificatesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ManagedCertificatesClient, error)`
info	[Changelog] - New function `*ManagedCertificatesClient.BeginCreateOrUpdate(context.Context, string, string, string, *ManagedCertificatesClientBeginCreateOrUpdateOptions) (*runtime.Poller[ManagedCertificatesClientCreateOrUpdateResponse], error)`
info	[Changelog] - New function `*ManagedCertificatesClient.Delete(context.Context, string, string, string, *ManagedCertificatesClientDeleteOptions) (ManagedCertificatesClientDeleteResponse, error)`
info	[Changelog] - New function `*ManagedCertificatesClient.Get(context.Context, string, string, string, *ManagedCertificatesClientGetOptions) (ManagedCertificatesClientGetResponse, error)`
info	[Changelog] - New function `*ManagedCertificatesClient.NewListPager(string, string, *ManagedCertificatesClientListOptions) *runtime.Pager[ManagedCertificatesClientListResponse]`
info	[Changelog] - New function `*ManagedCertificatesClient.Update(context.Context, string, string, string, ManagedCertificatePatch, *ManagedCertificatesClientUpdateOptions) (ManagedCertificatesClientUpdateResponse, error)`
info	[Changelog] - New struct `ContainerAppJobExecutions`
info	[Changelog] - New struct `CorsPolicy`
info	[Changelog] - New struct `DaprConfiguration`
info	[Changelog] - New struct `IngressStickySessions`
info	[Changelog] - New struct `Job`
info	[Changelog] - New struct `JobConfiguration`
info	[Changelog] - New struct `JobConfigurationEventTriggerConfig`
info	[Changelog] - New struct `JobConfigurationManualTriggerConfig`
info	[Changelog] - New struct `JobConfigurationScheduleTriggerConfig`
info	[Changelog] - New struct `JobExecution`
info	[Changelog] - New struct `JobExecutionBase`
info	[Changelog] - New struct `JobExecutionContainer`
info	[Changelog] - New struct `JobExecutionNamesCollection`
info	[Changelog] - New struct `JobExecutionTemplate`
info	[Changelog] - New struct `JobPatchProperties`
info	[Changelog] - New struct `JobPatchPropertiesProperties`
info	[Changelog] - New struct `JobProperties`
info	[Changelog] - New struct `JobSecretsCollection`
info	[Changelog] - New struct `JobTemplate`
info	[Changelog] - New struct `JobsCollection`
info	[Changelog] - New struct `KedaConfiguration`
info	[Changelog] - New struct `ManagedCertificate`
info	[Changelog] - New struct `ManagedCertificateCollection`
info	[Changelog] - New struct `ManagedCertificatePatch`
info	[Changelog] - New struct `ManagedCertificateProperties`
info	[Changelog] - New struct `ManagedEnvironmentPropertiesPeerAuthentication`
info	[Changelog] - New struct `Mtls`
info	[Changelog] - New struct `SecretVolumeItem`
info	[Changelog] - New field `Category` in struct `AvailableWorkloadProfileProperties`
info	[Changelog] - New field `Kind` in struct `AzureCredentials`
info	[Changelog] - New field `ManagedBy` in struct `ContainerApp`
info	[Changelog] - New field `LatestReadyRevisionName`, `WorkloadProfileName` in struct `ContainerAppProperties`
info	[Changelog] - New field `Identity`, `KeyVaultURL` in struct `ContainerAppSecret`
info	[Changelog] - New anonymous field `ContainerApp` in struct `ContainerAppsClientUpdateResponse`
info	[Changelog] - New field `GithubPersonalAccessToken` in struct `GithubActionConfiguration`
info	[Changelog] - New field `ClientCertificateMode`, `CorsPolicy`, `StickySessions` in struct `Ingress`
info	[Changelog] - New field `Kind` in struct `ManagedEnvironment`
info	[Changelog] - New field `DaprConfiguration`, `InfrastructureResourceGroup`, `KedaConfiguration`, `PeerAuthentication` in struct `ManagedEnvironmentProperties`
info	[Changelog] - New anonymous field `ManagedEnvironment` in struct `ManagedEnvironmentsClientUpdateResponse`
info	[Changelog] - New field `RunningState`, `RunningStateDetails` in struct `ReplicaContainer`
info	[Changelog] - New field `InitContainers`, `RunningState`, `RunningStateDetails` in struct `ReplicaProperties`
info	[Changelog] - New field `RunningState` in struct `RevisionProperties`
info	[Changelog] - New field `Identity`, `KeyVaultURL` in struct `Secret`
info	[Changelog] - New field `TerminationGracePeriodSeconds` in struct `Template`
info	[Changelog] - New field `MountOptions`, `Secrets` in struct `Volume`
info	[Changelog] - New field `SubPath` in struct `VolumeMount`
info	[Changelog] - New field `Name` in struct `WorkloadProfile`
info	[Changelog]
info	[Changelog] Total 14 breaking change(s), 144 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 4ff68ad199a247c0167768186894bec1f1edd241. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-appcontainers [View full logs] [Preview SDK Changes] Breaking Change Detected

azure-arm-appcontainers-2.0.0-beta.3.tgz

Only show 120 items here, please refer to log for details.

info	[Changelog]   - Added Type Alias ConnectedEnvironmentsStoragesCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsStoragesGetResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsStoragesListResponse
info	[Changelog]   - Added Type Alias ConnectedEnvironmentsUpdateResponse
info	[Changelog]   - Added Type Alias ContainerAppContainerRunningState
info	[Changelog]   - Added Type Alias ContainerAppReplicaRunningState
info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsGetDetectorResponse
info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsGetRevisionResponse
info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsGetRootResponse
info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsListDetectorsNextResponse
info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsListDetectorsResponse
info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsListRevisionsNextResponse
info	[Changelog]   - Added Type Alias ContainerAppsDiagnosticsListRevisionsResponse
info	[Changelog]   - Added Type Alias ContainerAppsGetAuthTokenResponse
info	[Changelog]   - Added Type Alias ContainerAppsUpdateResponse
info	[Changelog]   - Added Type Alias ExtendedLocationTypes
info	[Changelog]   - Added Type Alias IngressClientCertificateMode
info	[Changelog]   - Added Type Alias JobExecutionRunningState
info	[Changelog]   - Added Type Alias JobProvisioningState
info	[Changelog]   - Added Type Alias JobsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias JobsExecutionsListNextResponse
info	[Changelog]   - Added Type Alias JobsExecutionsListResponse
info	[Changelog]   - Added Type Alias JobsGetResponse
info	[Changelog]   - Added Type Alias JobsListByResourceGroupNextResponse
info	[Changelog]   - Added Type Alias JobsListByResourceGroupResponse
info	[Changelog]   - Added Type Alias JobsListBySubscriptionNextResponse
info	[Changelog]   - Added Type Alias JobsListBySubscriptionResponse
info	[Changelog]   - Added Type Alias JobsListSecretsResponse
info	[Changelog]   - Added Type Alias JobsStartResponse
info	[Changelog]   - Added Type Alias JobsStopMultipleExecutionsResponse
info	[Changelog]   - Added Type Alias JobsUpdateResponse
info	[Changelog]   - Added Type Alias LogLevel
info	[Changelog]   - Added Type Alias ManagedCertificateDomainControlValidation
info	[Changelog]   - Added Type Alias ManagedCertificatesCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias ManagedCertificatesGetResponse
info	[Changelog]   - Added Type Alias ManagedCertificatesListNextResponse
info	[Changelog]   - Added Type Alias ManagedCertificatesListResponse
info	[Changelog]   - Added Type Alias ManagedCertificatesUpdateResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentDiagnosticsGetDetectorResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentDiagnosticsListDetectorsResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentsDiagnosticsGetRootResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentsGetAuthTokenResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentsListWorkloadProfileStatesNextResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentsListWorkloadProfileStatesResponse
info	[Changelog]   - Added Type Alias ManagedEnvironmentsUpdateResponse
info	[Changelog]   - Added Type Alias RevisionRunningState
info	[Changelog]   - Added Type Alias TriggerType
info	[Changelog]   - Interface AzureCredentials has a new optional parameter kind
info	[Changelog]   - Interface CertificateProperties has a new optional parameter subjectAlternativeNames
info	[Changelog]   - Interface Configuration has a new optional parameter maxInactiveRevisions
info	[Changelog]   - Interface ContainerApp has a new optional parameter environmentId
info	[Changelog]   - Interface ContainerApp has a new optional parameter eventStreamEndpoint
info	[Changelog]   - Interface ContainerApp has a new optional parameter extendedLocation
info	[Changelog]   - Interface ContainerApp has a new optional parameter latestReadyRevisionName
info	[Changelog]   - Interface ContainerApp has a new optional parameter managedBy
info	[Changelog]   - Interface ContainerApp has a new optional parameter workloadProfileName
info	[Changelog]   - Interface ContainerAppSecret has a new optional parameter identity
info	[Changelog]   - Interface ContainerAppSecret has a new optional parameter keyVaultUrl
info	[Changelog]   - Interface CustomHostnameAnalysisResult has a new optional parameter conflictWithEnvironmentCustomDomain
info	[Changelog]   - Interface Dapr has a new optional parameter enableApiLogging
info	[Changelog]   - Interface Dapr has a new optional parameter httpMaxRequestSize
info	[Changelog]   - Interface Dapr has a new optional parameter httpReadBufferSize
info	[Changelog]   - Interface Dapr has a new optional parameter logLevel
info	[Changelog]   - Interface DaprComponent has a new optional parameter secretStoreComponent
info	[Changelog]   - Interface GithubActionConfiguration has a new optional parameter githubPersonalAccessToken
info	[Changelog]   - Interface Ingress has a new optional parameter clientCertificateMode
info	[Changelog]   - Interface Ingress has a new optional parameter corsPolicy
info	[Changelog]   - Interface Ingress has a new optional parameter exposedPort
info	[Changelog]   - Interface Ingress has a new optional parameter ipSecurityRestrictions
info	[Changelog]   - Interface Ingress has a new optional parameter stickySessions
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter customDomainConfiguration
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter daprConfiguration
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter eventStreamEndpoint
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter infrastructureResourceGroup
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter kedaConfiguration
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter kind
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter peerAuthentication
info	[Changelog]   - Interface ManagedEnvironment has a new optional parameter workloadProfiles
info	[Changelog]   - Interface Replica has a new optional parameter initContainers
info	[Changelog]   - Interface Replica has a new optional parameter runningState
info	[Changelog]   - Interface Replica has a new optional parameter runningStateDetails
info	[Changelog]   - Interface ReplicaContainer has a new optional parameter execEndpoint
info	[Changelog]   - Interface ReplicaContainer has a new optional parameter logStreamEndpoint
info	[Changelog]   - Interface ReplicaContainer has a new optional parameter runningState
info	[Changelog]   - Interface ReplicaContainer has a new optional parameter runningStateDetails
info	[Changelog]   - Interface Revision has a new optional parameter lastActiveTime
info	[Changelog]   - Interface Revision has a new optional parameter runningState
info	[Changelog]   - Interface ScaleRule has a new optional parameter tcp
info	[Changelog]   - Interface Secret has a new optional parameter identity
info	[Changelog]   - Interface Secret has a new optional parameter keyVaultUrl
info	[Changelog]   - Interface Template has a new optional parameter initContainers
info	[Changelog]   - Interface Template has a new optional parameter terminationGracePeriodSeconds
info	[Changelog]   - Interface Volume has a new optional parameter mountOptions
info	[Changelog]   - Interface Volume has a new optional parameter secrets
info	[Changelog]   - Interface VolumeMount has a new optional parameter subPath
info	[Changelog]   - Added Enum KnownAction
info	[Changelog]   - Added Enum KnownAffinity
info	[Changelog]   - Added Enum KnownApplicability
info	[Changelog]   - Added Enum KnownConnectedEnvironmentProvisioningState
info	[Changelog]   - Added Enum KnownContainerAppContainerRunningState
info	[Changelog]   - Added Enum KnownContainerAppReplicaRunningState
info	[Changelog]   - Added Enum KnownExtendedLocationTypes
info	[Changelog]   - Added Enum KnownIngressClientCertificateMode
info	[Changelog]   - Added Enum KnownJobExecutionRunningState
info	[Changelog]   - Added Enum KnownJobProvisioningState
info	[Changelog]   - Added Enum KnownLogLevel
info	[Changelog]   - Added Enum KnownManagedCertificateDomainControlValidation
info	[Changelog]   - Added Enum KnownRevisionRunningState
info	[Changelog]   - Added Enum KnownTriggerType
info	[Changelog]   - Enum KnownContainerAppProvisioningState has a new value Deleting
info	[Changelog]   - Enum KnownIngressTransportMethod has a new value Tcp
info	[Changelog]   - Enum KnownStorageType has a new value Secret
info	[Changelog]   - Added function getContinuationToken
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Interface ContainerAppsRevisionsListRevisionsNextOptionalParams no longer has parameter filter
info	[Changelog]   - Interface VnetConfiguration no longer has parameter runtimeSubnetId
info	[Changelog]   - Type of parameter customDomainVerificationFailureInfo of interface CustomHostnameAnalysisResult is changed from DefaultErrorResponse to CustomHostnameAnalysisResultCustomDomainVerificationFailureInfo
info	[Changelog]   - Type of parameter value of interface DaprSecretsCollection is changed from Secret[] to DaprSecret[]

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs] Generate from 4ff68ad199a247c0167768186894bec1f1edd241. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️app [View full logs] [Preview Schema Changes]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs] Generate from 4ff68ad199a247c0167768186894bec1f1edd241. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Connection reset by peer
Error: SSL error: syscall failure: Connection reset by peer

️✔️Az.app.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Connection reset by peer
error	The following packages are still pending:
error		Az.app.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-05-09T23:02:18Z

Generated ApiView

Language	Package Name	ApiView Link
Swagger	Microsoft.App	https://apiview.dev/Assemblies/Review/1e10b9aa2c124533820a3c2ae759fc13
Go	sdk/resourcemanager/appcontainers/armappcontainers	https://apiview.dev/Assemblies/Review/31bd2971500c455abfc1999b84f95b55
Java	azure-resourcemanager-appcontainers	https://apiview.dev/Assemblies/Review/c54569275e244cb1804754e417c7a09c
JavaScript	@azure/arm-appcontainers	https://apiview.dev/Assemblies/Review/3e04306134eb41008ec9baf39c4efaf1

xwang971 · 2023-05-09T23:06:29Z

Can we update examples as well

please update examples

openapi-workflow-bot · 2023-05-11T21:14:39Z

Hi @sanchitmehta, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

xwang971 · 2023-05-11T22:12:36Z

@kazrael2119 Hi, can we get approval please? The examples have been added

kazrael2119 · 2023-05-12T01:57:13Z

/azp run

azure-pipelines · 2023-05-12T01:57:22Z

Azure Pipelines successfully started running 1 pipeline(s).

weshaggard · 2023-05-12T16:21:27Z

/azp run

azure-pipelines · 2023-05-12T16:21:36Z

Azure Pipelines successfully started running 1 pipeline(s).

weshaggard · 2023-05-12T20:48:41Z

/azp run

azure-pipelines · 2023-05-12T20:48:50Z

Azure Pipelines successfully started running 1 pipeline(s).

kazrael2119 · 2023-05-15T01:55:45Z

@sanchitmehta ,please fix ModelValidation error

sanchitmehta · 2023-05-16T00:46:41Z

@kazrael2119 realized the example was wrong and I fixed it

sanchitmehta · 2023-05-16T00:47:02Z

/azp run

azure-pipelines · 2023-05-16T00:47:08Z

Commenter does not have sufficient privileges for PR 23891 in repo Azure/azure-rest-api-specs

kazrael2119

skip sdk breaking change review beacuse they are not from this PR

* Adds base for updating Microsoft.App from version preview/2022-11-01-preview to version 2023-04-01-preview * Updates readme * Updates API version in new specs and examples * support terminationGracePeriodSeconds (#23476) * Support SubPath in volume mount and mount options for azure file volume (#23496) * Support SubPath in volume mount and mount options for azure file volume * update description * Add replica/container running state (#23617) * add replica/container running state * spell error fix * add event trigger for Container Jobs 2023-04-01-preview (#23724) * add event trigger for Container Jobs 2023-04-01-preview * prettier and avocado fix --------- Co-authored-by: Taher Darolywala <[email protected]> * Resolve Comments for Event driven jobs (#23729) * Resolve Comments for Event driven jobs * change scaling rule to azure-servicebus * update example --------- Co-authored-by: Taher Darolywala <[email protected]> * Swagger change for mtls and runningState (#23767) * 1. Add mtls properties for managed ManagedEnvironment 2. Add running state for Revision * fix * Add ContainerApp Start/Stop for 2023-04-01-preview (#23497) * Add ContainerApp Start/Stop for 2023-04-01-preview * Fix validation error * Fix validation error * Change example to add location in header * Fix lint error * Fix lint issue * Fix lint issue * Fix lint issue * Fix lint issue * Fix lint issue * Fix lint issue * Fix lint issue * Fix lint issue * Add new source controls properties (#23891) * Add new source controls properties * Update examples * fix examples * Change event trigger replica properties to executions, add polling in… (#23810) * Change event trigger replica properties to executions, add polling interval to event trigger, fix typos and descriptions to accommodate both apps and jobs * Fix validation errors * code review comments * Fix formatting errors * Code review comments * Add single execution history endpoint, refactor copy paste code for j… (#23816) * Add single execution history endpoint, refactor copy paste code for jobName and jobExecutionName path parameters * Fix validation errors from ARM * Fix validation errors * Code review comments * Fix validation error * code review comments from Anand * Add springboard properties (#23932) * Add springboard properties * CR comments * Update specification/app/resource-manager/Microsoft.App/preview/2023-04-01-preview/examples/ContainerApps_CreateOrUpdate.json Co-authored-by: Jitin John <[email protected]> * Update specification/app/resource-manager/Microsoft.App/preview/2023-04-01-preview/examples/ContainerApps_CreateOrUpdate.json Co-authored-by: Jitin John <[email protected]> --------- Co-authored-by: Jitin John <[email protected]> * Fix Lint issues in ContainerApps.json (#24107) * Fix lint issue * Fix format issue * Fix json format issue * Fix model validation * Fix lint error * fix param (#24166) Co-authored-by: Chenghui Yu <[email protected]> --------- Co-authored-by: Zunli Hu <[email protected]> Co-authored-by: njucz <[email protected]> Co-authored-by: LaylaLiu-gmail <[email protected]> Co-authored-by: Xingjian Wang <[email protected]> Co-authored-by: Taher Daroly <[email protected]> Co-authored-by: Taher Darolywala <[email protected]> Co-authored-by: zhenqxuMSFT <[email protected]> Co-authored-by: Zijian-Ju <[email protected]> Co-authored-by: Sanchit Mehta <[email protected]> Co-authored-by: trajkobal <[email protected]> Co-authored-by: Ahmed ElSayed <[email protected]> Co-authored-by: Jitin John <[email protected]> Co-authored-by: Seris370 <[email protected]> Co-authored-by: Chenghui Yu <[email protected]>

Add new source controls properties

dba7757

openapi-assignment-bot bot assigned kazrael2119 May 9, 2023

azure-sdk mentioned this pull request May 9, 2023

[AutoPR sdk/resourcemanager/appcontainers/armappcontainers] Add new source controls properties azure-sdk/azure-sdk-for-go#5625

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label May 9, 2023

azure-sdk mentioned this pull request May 9, 2023

[AutoPR app] Add new source controls properties azure-sdk/azure-resource-manager-schemas#2555

Draft

AzureRestAPISpecReview added the resource-manager label May 9, 2023

azure-sdk mentioned this pull request May 9, 2023

[AutoPR track2_azure-mgmt-appcontainers] Add new source controls properties azure-sdk/azure-sdk-for-python#3500

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label May 9, 2023

azure-sdk mentioned this pull request May 9, 2023

[AutoPR @azure/arm-appcontainers] Add new source controls properties azure-sdk/azure-sdk-for-js#5040

Closed

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label May 9, 2023

azure-sdk mentioned this pull request May 9, 2023

[AutoPR azure-resourcemanager-appcontainers] Add new source controls properties azure-sdk/azure-sdk-for-java#5340

Closed

kazrael2119 previously approved these changes May 10, 2023

View reviewed changes

msyyc added the Approved-SdkBreakingChange-Python label May 10, 2023

Update examples

0342f04

AzureRestAPISpecReview added the CI-FixRequiredOnFailure label May 11, 2023

xwang971 approved these changes May 11, 2023

View reviewed changes

raych1 mentioned this pull request May 12, 2023

[Unified pipeline] Pipeline result fails to sync to github PR Azure/azure-sdk-tools#6143

Closed

fix examples

280e9e9

kazrael2119 approved these changes May 16, 2023

View reviewed changes

kazrael2119 added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label May 16, 2023

tadelesh merged commit a7f520b into Azure:release-app-Microsoft.App-2023-04-01-preview May 17, 2023

Add new source controls properties #23891

Add new source controls properties #23891

Uh oh!

Conversation

sanchitmehta commented May 9, 2023

Uh oh!

openapi-workflow-bot bot commented May 9, 2023

Uh oh!

openapi-pipeline-app bot commented May 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented May 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented May 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

xwang971 commented May 9, 2023

Uh oh!

openapi-workflow-bot bot commented May 11, 2023

Uh oh!

xwang971 commented May 11, 2023

Uh oh!

kazrael2119 commented May 12, 2023

Uh oh!

azure-pipelines bot commented May 12, 2023

Uh oh!

weshaggard commented May 12, 2023

Uh oh!

azure-pipelines bot commented May 12, 2023

Uh oh!

weshaggard commented May 12, 2023

Uh oh!

azure-pipelines bot commented May 12, 2023

Uh oh!

kazrael2119 commented May 15, 2023

Uh oh!

sanchitmehta commented May 16, 2023

Uh oh!

sanchitmehta commented May 16, 2023

Uh oh!

azure-pipelines bot commented May 16, 2023

Uh oh!

kazrael2119 left a comment • edited by tadelesh Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

openapi-pipeline-app bot commented May 9, 2023 •

edited

Loading

openapi-pipeline-app bot commented May 9, 2023 •

edited

Loading

openapi-pipeline-app bot commented May 9, 2023 •

edited

Loading

kazrael2119 left a comment •

edited by tadelesh

Loading