Skip to content

Add new source controls properties #23891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tadelesh merged 3 commits into from
May 17, 2023
Merged

Add new source controls properties #23891

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dba7757
Add new source controls properties
sanchitmehta May 9, 2023
0342f04
Update examples
sanchitmehta May 11, 2023
280e9e9
fix examples
sanchitmehta May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions ...ication/app/resource-manager/Microsoft.App/preview/2023-04-01-preview/SourceControls.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,15 @@
"description": "Context path",
"type": "string"
},
"githubPersonalAccessToken": {
"description": "One time Github PAT to configure github environment",
"type": "string",
"x-ms-mutability": [
"create",
"update"
],
"x-ms-secret": true
},
"image": {
"description": "Image name",
"type": "string"
Expand Down Expand Up @@ -398,6 +407,14 @@
],
"x-ms-secret": true
},
"kind": {
"description": "Kind of auth github does for deploying the template",
"type": "string",
"x-ms-mutability": [
"create",
"update"
]
},
"subscriptionId": {
"description": "Subscription Id.",
"type": "string"
Expand Down
20 changes: 12 additions & 8 deletions ...ager/Microsoft.App/preview/2023-04-01-preview/examples/SourceControls_CreateOrUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,19 @@
"branch": "master",
"githubActionConfiguration": {
"registryInfo": {
"registryUrl": "xwang971reg.azurecr.io",
"registryUserName": "xwang971reg",
"registryPassword": "<registrypassword>"
"registryUrl": "test-registry.azurecr.io",
"registryUserName": "test-registry",
"registryPassword": "<registrypassword>",
"kind": "feaderated"
},
"azureCredentials": {
"clientId": "<clientid>",
"clientSecret": "<clientsecret>",
"tenantId": "<tenantid>"
},
"contextPath": "./",
"image": "image/tag"
"image": "image/tag",
"githubPersonalAccessToken": "test"
}
}
}
Expand All @@ -39,8 +41,9 @@
"branch": "master",
"githubActionConfiguration": {
"registryInfo": {
"registryUrl": "xwang971reg.azurecr.io",
"registryUserName": "xwang971reg"
"registryUrl": "test-registry.azurecr.io",
"registryUserName": "testreg",
"kind": "feaderated"
},
"contextPath": "./",
"image": "image/tag"
Expand All @@ -62,8 +65,9 @@
"branch": "master",
"githubActionConfiguration": {
"registryInfo": {
"registryUrl": "xwang971reg.azurecr.io",
"registryUserName": "xwang971reg"
"registryUrl": "test-registry.azurecr.io",
"registryUserName": "test-registry",
"kind": "feaderated"
},
"contextPath": "./",
"image": "image/tag"
Expand Down