AzAutomation Swagger for job & runbook #2466
Conversation
softwareUpdateConfigurationCollectionItemProperties
Automation for azure-sdk-for-pythonA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-goEncountered a Subprocess error: (azure-sdk-for-go)
Command: profileBuilder -s list -l ./profiles/2017-03-09/defintion.txt -name 2017-03-09 Error: unknown command "2017-03-09" for "profileBuilder"
Run 'profileBuilder --help' for usage.
unknown command "2017-03-09" for "profileBuilder" |
sergey-shandar
added
the
WaitForARMFeedback
|
@najams - Could you please take a look at the error that the Python build faced - #2466 (comment) |
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
|
Hi @ravbhatnagar, @sergey-shandar - Could you please take a look at this PR. Thanks. |
| "format": "date-time", | ||
| "description": "The end time of the job." | ||
| }, | ||
| "lastModifiedTime": { |
| "format": "date-time", | ||
| "description": "The start time of the job." | ||
| }, | ||
| "endTime": { |
| "format": "date-time", | ||
| "description": "The last modified time of the job." | ||
| }, | ||
| "provisioningState": { |
| "$ref": "./definitions.json#/parameters/clientRequestId" | ||
| } | ||
| ], | ||
| "responses": { |
There was a problem hiding this comment.
what does this return? does it not have a defined schema.
There was a problem hiding this comment.
It returns the output from the script as generated by Powershell. For example, a script with only statement as { get-date } will generate the following output: Saturday, February 17, 2018 10:09:38 PM
whereas, the script like { "hello"; get-date; "bye"; } will generate the output:
hello
Saturday, February 17, 2018 10:11:15 PM
bye
| "$ref": "./definitions.json#/parameters/clientRequestId" | ||
| } | ||
| ], | ||
| "responses": { |
There was a problem hiding this comment.
This will be a string which represents the script used to run the job. As above, there is no schema as it is a script.
| "produces": [ | ||
| "application/json" | ||
| "application/json", | ||
| "text/plain", |
There was a problem hiding this comment.
Are you really returning these content types from the ARM control plane? text/plain and text/powershell. Please note that only json is supported.
There was a problem hiding this comment.
Yes, these are for the scripts and output as commented above. These are for read-only properties. These APIs are part of ARM since day 1 and signed off by ARM team like Charles, Anders, etc. I only fixed the swagger. Also, these are not used in ARM templates.
| "description": "The Resource definition.", | ||
| "x-ms-azure-resource": true | ||
| }, | ||
| "ProvisioningStateProperty": { |
| } | ||
| }, | ||
| "produces": [ | ||
| "text/powershell" |
There was a problem hiding this comment.
content type is an issue
|
Hi @ravbhatnagar, I have addressed your feedback. Please review and let me know if you have more questions. Overall, these are existing GA APIs out for several years. Thanks. |
|
Signing off since these are existing APIs. ARM content type validation needs to be enabled going forward to disallow such behavior. |
ravbhatnagar
added
ARMSignedOff
8 participants
Uh oh!
There was an error while loading. Please reload this page.