Skip to content

Conversation

@vrdmr
Copy link
Member

@vrdmr vrdmr commented Apr 3, 2018

Description

Generating new SDK for changes added in the following Rest API Specs PR:


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@vrdmr
Copy link
Member Author

vrdmr commented Apr 4, 2018

Looking at the examples now. FYI @finiteattractor @MiaRomero

@dsgouda
Copy link
Contributor

dsgouda commented Apr 4, 2018

@vrdmr please fix the failing test cases

@dsgouda dsgouda self-assigned this Apr 4, 2018
@dsgouda
Copy link
Contributor

dsgouda commented Apr 11, 2018

@azuresdkci retest this please

@vrdmr
Copy link
Member Author

vrdmr commented Apr 13, 2018

Hi @dsgouda. I am closing this SDK PR as we need to fix some more things in the Swagger Spec. I'll create a new PR. Thanks.

@vrdmr vrdmr closed this Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants