Skip to content

Azure Search: Add resource identity (MSI) support #3377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jhendrixMSFT merged 2 commits into from
Jul 10, 2018
Merged

Azure Search: Add resource identity (MSI) support #3377

jhendrixMSFT merged 2 commits into from
Jul 10, 2018

Conversation

@natinimni
Copy link
Contributor

@natinimni natinimni commented Jul 9, 2018 •
edited by azuresdkci
Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Jul 9, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2901

@azuresdkci azuresdkci requested a review from jhendrixMSFT July 9, 2018 21:22
@AutorestCI
Copy link

AutorestCI commented Jul 9, 2018 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2206

@AutorestCI
Copy link

AutorestCI commented Jul 9, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1463

@AutorestCI
Copy link

AutorestCI commented Jul 9, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3149

@AutorestCI
Copy link

AutorestCI commented Jul 9, 2018 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2205

@natinimni
Copy link
Contributor Author

natinimni commented Jul 9, 2018

@brjohnstmsft

This was referenced Jul 9, 2018
Merged
Merged
@natinimni
Copy link
Contributor Author

natinimni commented Jul 9, 2018

@mhko

This was referenced Jul 9, 2018
Merged
Merged
Merged
@natinimni
Copy link
Contributor Author

natinimni commented Jul 9, 2018

@abhishek225

@mhko
Copy link
Member

mhko commented Jul 9, 2018

Shouldn't this feature be in preview version?

@natinimni
Copy link
Contributor Author

natinimni commented Jul 9, 2018 •
edited
Loading

This feature doesn't need to be in a preview version as it is backward compatible due to the following:

  1. One can request identity to be assigned to a previously created service
  2. If a service with an identity is being updated but the identity field is missing, the identity will not be deleted

@mhko
Copy link
Member

mhko commented Jul 10, 2018

Thanks, Nati. LGTM

@jhendrixMSFT jhendrixMSFT merged commit e97dba0 into Azure:master Jul 10, 2018
abhi1509
abhi1509 reviewed Jul 10, 2018
View reviewed changes
specification/search/resource-manager/Microsoft.Search/stable/2015-08-19/search.json
"enum": [
"SystemAssigned"
],
"x-ms-enum": {
Copy link

@abhi1509 abhi1509 Jul 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed, let's see if we really need this

brjohnstmsft
brjohnstmsft reviewed Jul 29, 2018
View reviewed changes
specification/search/resource-manager/Microsoft.Search/stable/2015-08-19/search.json
"principalId": {
"readOnly": true,
"type": "string",
"description": "The principal ID of resource identity."
Copy link
Member

@brjohnstmsft brjohnstmsft Jul 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The principal ID of the resource identity.

specification/search/resource-manager/Microsoft.Search/stable/2015-08-19/search.json
"tenantId": {
"readOnly": true,
"type": "string",
"description": "The tenant ID of resource."
Copy link
Member

@brjohnstmsft brjohnstmsft Jul 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tenant ID of the resource.

specification/search/resource-manager/Microsoft.Search/stable/2015-08-19/search.json
},
"type": {
"type": "string",
"description": "The identity type.",
Copy link
Member

@brjohnstmsft brjohnstmsft Jul 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there more detail we can add here so the generated documentation will be more self-explanatory?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

+2 more reviewers

@brjohnstmsft brjohnstmsft brjohnstmsft left review comments

@abhi1509 abhi1509 abhi1509 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jhendrixMSFT jhendrixMSFT

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@natinimni @AutorestCI @mhko @brjohnstmsft @jhendrixMSFT @abhi1509