Skip to content

Azure Search: Add resource identity (MSI) support #3377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhendrixMSFT merged 2 commits into from
Jul 10, 2018
Merged

Azure Search: Add resource identity (MSI) support #3377

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9fa1e4
Azure Search: Add resource identity (MSI) support
natinimni Jul 9, 2018
93a610b
Azure Search: Removing redundant commas
natinimni Jul 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions specification/search/resource-manager/Microsoft.Search/stable/2015-08-19/search.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -904,6 +904,10 @@
"type": "string"
},
"description": "Tags to help categorize the resource in the Azure portal."
},
"identity": {
"$ref": "#/definitions/Identity",
"description": "The identity of the resource."
}
},
"description": "Base type for all Azure resources.",
Expand Down Expand Up @@ -1000,6 +1004,35 @@
"description": "The URL to get the next set of operation list results, if any."
}
}
},
"Identity": {
"properties": {
"principalId": {
"readOnly": true,
"type": "string",
"description": "The principal ID of resource identity."
Copy link
Member

@brjohnstmsft brjohnstmsft Jul 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The principal ID of the resource identity.

},
"tenantId": {
"readOnly": true,
"type": "string",
"description": "The tenant ID of resource."
Copy link
Member

@brjohnstmsft brjohnstmsft Jul 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tenant ID of the resource.

},
"type": {
"type": "string",
"description": "The identity type.",
Copy link
Member

@brjohnstmsft brjohnstmsft Jul 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there more detail we can add here so the generated documentation will be more self-explanatory?

"enum": [
"SystemAssigned"
],
"x-ms-enum": {
Copy link

@abhi1509 abhi1509 Jul 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed, let's see if we really need this

"name": "IdentityType",
"modelAsString": false
}
}
},
"required": [
"type"
],
"description": "Identity for the resource."
}
},
"parameters": {
Expand Down