Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
69 commits
Select commit Hold shift + click to select a range
33460a8
add unit tests for the existing logic. time to update the logic to on…
scbedd Jul 9, 2025
b8d396d
update the test. we're fe failing now!
scbedd Jul 10, 2025
d1f693f
getting closer! 5/10 tests passing
scbedd Jul 10, 2025
40881f1
updates. I seriously think this might work
scbedd Jul 10, 2025
df96c1a
correct tests and lint
scbedd Jul 10, 2025
d5a64a3
including tests
scbedd Jul 10, 2025
6698b45
factor review labels out
scbedd Jul 10, 2025
a69c26a
adding labelcontext
scbedd Jul 11, 2025
c6eeffc
pulling some items across. still broken state
scbedd Jul 11, 2025
a507134
pull across a bunch more stuff. the pr context is going to need a ton…
scbedd Jul 12, 2025
5e3e8ea
reworking this entire deal. ton of work necessary
scbedd Jul 15, 2025
cd971b3
making a ton of progress. almnomost got it!
scbedd Jul 15, 2025
0779939
lotta changes for stability. we are actually getting pretty damn clos…
scbedd Jul 16, 2025
7b702b7
clean build. time to start integration testing while eliminating the …
scbedd Jul 16, 2025
e8218ea
resolve conflicts
scbedd Jul 16, 2025
6ee3555
have a working integration test! time to fight through this
scbedd Jul 16, 2025
485001a
honhonor new arg
scbedd Jul 16, 2025
d9794b9
really clean up the codebase. starting to lean harder into the readme…
scbedd Jul 17, 2025
942e2ed
processSuppression isn't working the way it should
scbedd Jul 17, 2025
9c71c67
update the checks for necessary changes
scbedd Jul 17, 2025
e49d364
saving a checkpoint. can I trust the suppression result now?
scbedd Jul 18, 2025
66d3c14
we are properly recognizing suppression required now!
scbedd Jul 18, 2025
bfb4296
discovscovered new issue with looking for the breaking change labels.
scbedd Jul 18, 2025
87a9bf7
update formatting
scbedd Jul 18, 2025
2278f92
starting cleanup refactors. only a couple todo to take care of
scbedd Jul 18, 2025
5ae3ef5
we're actually properly processing now. we should be able to publish …
scbedd Jul 19, 2025
e5123fe
merge readme changes
scbedd Jul 19, 2025
21ba5dd
reflect necessary updates to package lock
scbedd Jul 19, 2025
485b851
build explicitly
scbedd Jul 19, 2025
d256ca9
install glob
scbedd Jul 19, 2025
afbfc80
build this thing
scbedd Jul 19, 2025
f4e73fc
we can't use short refs that are more than single character
scbedd Jul 19, 2025
31e59b0
we need to run in context of the checked out directory after
scbedd Jul 19, 2025
07a8ed1
need to make certain that the paths will resolve
scbedd Jul 19, 2025
7993026
a couple updates for the output
scbedd Jul 19, 2025
eb96802
adding a bunch of logging and surrounding the crashing function in tr…
scbedd Jul 19, 2025
d067bfe
evaluate that impact!
scbedd Jul 19, 2025
3178897
fix summarize checks yaml. ensure we don't fail to get ratelimit (bec…
scbedd Jul 20, 2025
cda9c5e
oodles more updates! time to close the loop between the two checks!
scbedd Jul 20, 2025
59b6528
fallback for issue number
scbedd Jul 20, 2025
ebf4703
bump how we calculate
scbedd Jul 20, 2025
354d502
fix the issue with outputs
scbedd Jul 20, 2025
ac48429
Merge branch 'main' into add-label-processing
scbedd Jul 20, 2025
99d44b5
properly process workflows now
scbedd Jul 20, 2025
3717ef6
getting necessary metaadata in graphql. we should be able to download…
scbedd Jul 20, 2025
9295587
save progress
scbedd Jul 20, 2025
01d83d5
download of the artifact now!
scbedd Jul 20, 2025
ccc4a00
we should get back the correct pr now
scbedd Jul 21, 2025
b7304f0
another small update to see if we can change our fallback
scbedd Jul 21, 2025
dd05dad
more debugging
scbedd Jul 21, 2025
7e91ceb
remove timeout from summarize-checks.test.js. ensure my integration t…
scbedd Jul 21, 2025
145c793
restore context.js to main version
scbedd Jul 21, 2025
c568b2a
revert issues.js to original from main
scbedd Jul 21, 2025
d69d8a5
add my package to tsconfig. add the issue number publication to summa…
scbedd Jul 21, 2025
58eaa8a
eliminate pointless checkout
scbedd Jul 22, 2025
d4a56fa
apply formatting fixes
scbedd Jul 22, 2025
1408f26
expectation of the test should align with reality
scbedd Jul 22, 2025
119415f
call them frappropriately
scbedd Jul 22, 2025
a3bd0ab
save label update
scbedd Jul 22, 2025
0de8046
fix the issues with the require vs import usage
scbedd Jul 22, 2025
0fc5f4e
split up the types as is reasonable.
scbedd Jul 22, 2025
d49ce77
use correct targeting
scbedd Jul 22, 2025
c09b63e
fix label tests. needed to update thetest to reflect how update-label…
scbedd Jul 22, 2025
035f4f1
moving our simple-git usage to a helper
scbedd Jul 22, 2025
c213321
moving simple-git interaction to helper
scbedd Jul 22, 2025
944407a
cleanup comments
scbedd Jul 22, 2025
456cee8
apply formatting fixes
scbedd Jul 22, 2025
c6c8111
swap over to async + use execFile from shared
scbedd Jul 22, 2025
27232c3
fix linting issue to unblock merge
scbedd Jul 22, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
moving our simple-git usage to a helper
  • Loading branch information
scbedd committed Jul 22, 2025
commit 035f4f1c63ca73e7906aa2b841e605aec2f63441
13 changes: 13 additions & 0 deletions .github/shared/src/simple-git.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
import { simpleGit } from "simple-git";
import { resolve } from "path";

/**
*
* @param {string} inputPath
* @returns {Promise<string>}
*/
export async function getRootFolder(inputPath) {
// expecting users to handle the case where inputPath is not a git repo
const gitRoot = await simpleGit(inputPath).revparse("--show-toplevel");
return resolve(gitRoot.trim());
}
24 changes: 24 additions & 0 deletions .github/shared/test/simple-git.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
import path from 'path';
import os from 'os';
import { mkdtemp, rm } from 'fs/promises';
import { getRootFolder } from '../src/simple-git.js';
import { describe, expect, it } from "vitest";

describe('getRootFolder', () => {
it('resolves to repo root from a nested folder', async () => {
// Use __dirname (this test file directory) as input to getRootFolder
const testDir = __dirname;
const calculatedRoot = await getRootFolder(testDir);
// Expect the repository root 3 levels up from this test file
const expectedRoot = path.resolve(path.join(__dirname, '..', '..', '..'));
expect(calculatedRoot).toBe(expectedRoot);
});

it('throws when directory is not a git repository', async () => {
// Use async mkdtemp from fs/promises
const tempDir = await mkdtemp(path.join(os.tmpdir(), 'non-git-'));
await expect(getRootFolder(tempDir)).rejects.toThrow();
// Cleanup the temp directory
await rm(tempDir, { recursive: true, force: true });
});
});