-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Add summarize-impact check, handle label additions in summarize-checks
#35951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
69 commits
Select commit
Hold shift + click to select a range
33460a8
add unit tests for the existing logic. time to update the logic to on…
scbedd b8d396d
update the test. we're fe failing now!
scbedd d1f693f
getting closer! 5/10 tests passing
scbedd 40881f1
updates. I seriously think this might work
scbedd df96c1a
correct tests and lint
scbedd d5a64a3
including tests
scbedd 6698b45
factor review labels out
scbedd a69c26a
adding labelcontext
scbedd c6eeffc
pulling some items across. still broken state
scbedd a507134
pull across a bunch more stuff. the pr context is going to need a ton…
scbedd 5e3e8ea
reworking this entire deal. ton of work necessary
scbedd cd971b3
making a ton of progress. almnomost got it!
scbedd 0779939
lotta changes for stability. we are actually getting pretty damn clos…
scbedd 7b702b7
clean build. time to start integration testing while eliminating the …
scbedd e8218ea
resolve conflicts
scbedd 6ee3555
have a working integration test! time to fight through this
scbedd 485001a
honhonor new arg
scbedd d9794b9
really clean up the codebase. starting to lean harder into the readme…
scbedd 942e2ed
processSuppression isn't working the way it should
scbedd 9c71c67
update the checks for necessary changes
scbedd e49d364
saving a checkpoint. can I trust the suppression result now?
scbedd 66d3c14
we are properly recognizing suppression required now!
scbedd bfb4296
discovscovered new issue with looking for the breaking change labels.
scbedd 87a9bf7
update formatting
scbedd 2278f92
starting cleanup refactors. only a couple todo to take care of
scbedd 5ae3ef5
we're actually properly processing now. we should be able to publish …
scbedd e5123fe
merge readme changes
scbedd 21ba5dd
reflect necessary updates to package lock
scbedd 485b851
build explicitly
scbedd d256ca9
install glob
scbedd afbfc80
build this thing
scbedd f4e73fc
we can't use short refs that are more than single character
scbedd 31e59b0
we need to run in context of the checked out directory after
scbedd 07a8ed1
need to make certain that the paths will resolve
scbedd 7993026
a couple updates for the output
scbedd eb96802
adding a bunch of logging and surrounding the crashing function in tr…
scbedd d067bfe
evaluate that impact!
scbedd 3178897
fix summarize checks yaml. ensure we don't fail to get ratelimit (bec…
scbedd cda9c5e
oodles more updates! time to close the loop between the two checks!
scbedd 59b6528
fallback for issue number
scbedd ebf4703
bump how we calculate
scbedd 354d502
fix the issue with outputs
scbedd ac48429
Merge branch 'main' into add-label-processing
scbedd 99d44b5
properly process workflows now
scbedd 3717ef6
getting necessary metaadata in graphql. we should be able to download…
scbedd 9295587
save progress
scbedd 01d83d5
download of the artifact now!
scbedd ccc4a00
we should get back the correct pr now
scbedd b7304f0
another small update to see if we can change our fallback
scbedd dd05dad
more debugging
scbedd 7e91ceb
remove timeout from summarize-checks.test.js. ensure my integration t…
scbedd 145c793
restore context.js to main version
scbedd c568b2a
revert issues.js to original from main
scbedd d69d8a5
add my package to tsconfig. add the issue number publication to summa…
scbedd 58eaa8a
eliminate pointless checkout
scbedd d4a56fa
apply formatting fixes
scbedd 1408f26
expectation of the test should align with reality
scbedd 119415f
call them frappropriately
scbedd a3bd0ab
save label update
scbedd 0de8046
fix the issues with the require vs import usage
scbedd 0fc5f4e
split up the types as is reasonable.
scbedd d49ce77
use correct targeting
scbedd c09b63e
fix label tests. needed to update thetest to reflect how update-label…
scbedd 035f4f1
moving our simple-git usage to a helper
scbedd c213321
moving simple-git interaction to helper
scbedd 944407a
cleanup comments
scbedd 456cee8
apply formatting fixes
scbedd c6c8111
swap over to async + use execFile from shared
scbedd 27232c3
fix linting issue to unblock merge
scbedd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
another small update to see if we can change our fallback
- Loading branch information
commit b7304f049c55513d1a0c9fb81e3631f6f2c50417
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.