Skip to content

[summarize-checks] Code cleanup and refactoring #36367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikeharder merged 15 commits into from
Jul 31, 2025
Merged

[summarize-checks] Code cleanup and refactoring #36367

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
2a19324
Move JS to separate file for ergonomics
mikeharder Jul 31, 2025
e2e2693
Add types
mikeharder Jul 31, 2025
b7ca7c2
trigger on pull_request for testing
mikeharder Jul 31, 2025
c1f8417
Revert "trigger on pull_request for testing"
mikeharder Jul 31, 2025
15ee5a3
add TODO
mikeharder Jul 31, 2025
7c9c1e3
remove duplicate logging of impactAssessment
mikeharder Jul 31, 2025
e5da68b
remove unused parameter
mikeharder Jul 31, 2025
a3c99ae
[.github/shared] Add set.intersect()
mikeharder Jul 31, 2025
a2c1981
Remove hints for inferred types, use set.intersect
mikeharder Jul 31, 2025
dbc2b45
[set.js] improve tests
mikeharder Jul 31, 2025
1cbb062
[set.js] Improve perf of intersect
mikeharder Jul 31, 2025
b553939
remove inferrable type comments
mikeharder Jul 31, 2025
8791ea3
Merge branch 'main' into summarize-checks-cleanup
mikeharder Jul 31, 2025
db0ae69
Merge branch 'main' into summarize-checks-cleanup
mikeharder Jul 31, 2025
4e23c82
Merge branch 'main' into summarize-checks-cleanup
mikeharder Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[set.js] improve tests
  • Loading branch information
@mikeharder
mikeharder committed Jul 31, 2025
commit dbc2b4583cdf0babc176c8f643833ede1702ff48
13 changes: 10 additions & 3 deletions .github/shared/test/set.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
// @ts-check

import { describe, expect, it } from "vitest";
Expand All @@ -6,6 +6,7 @@
describe("set", () => {
it.each([
[[], [], []],
[[1, 2, 3], [], []],
[
[1, 2, 3],
[2, 3, 4],
Expand All @@ -25,11 +26,17 @@
])(
"intersect(%o, %o, %o)",
async (
/** @type {(string|number)[]} */ setA,
/** @type {(string|number)[]} */ setB,
/** @type {(string|number)[]} */ a,
/** @type {(string|number)[]} */ b,
/** @type {(string|number)[]} */ result,
) => {
expect(intersect(new Set(setA), new Set(setB))).toEqual(new Set(result));
const setA = new Set(a);
const setB = new Set(b);
const setResult = new Set(result);

// Check both orders, result should be same
expect(intersect(setA, setB)).toEqual(setResult);
expect(intersect(setB, setA)).toEqual(setResult);
},
);
});
Loading