[summarize-checks] Code cleanup and refactoring #36367
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| // @ts-check | ||
|
|
||
| /** | ||
| * @template T | ||
| * @param {Set<T>} a | ||
| * @param {Set<T>} b | ||
| * @returns {Set<T>} | ||
| */ | ||
| export function intersect(a, b) { | ||
| // Since set lookup is O(1), iterate over the smaller set for better perf: O(small) vs O(large) | ||
| const [small, large] = a.size < b.size ? [a, b] : [b, a]; | ||
| return new Set([...small].filter((value) => large.has(value))); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| // @ts-check | ||
|
|
||
| import { describe, expect, it } from "vitest"; | ||
| import { intersect } from "../src/set"; | ||
|
|
||
| describe("set", () => { | ||
| it.each([ | ||
| [[], [], []], | ||
| [[1, 2, 3], [], []], | ||
| [ | ||
| [1, 2, 3], | ||
| [2, 3, 4], | ||
| [2, 3], | ||
| ], | ||
| [[1, 2, 3], [4, 5, 6], []], | ||
| [ | ||
| [1, 2, 3], | ||
| [1, 2, 3], | ||
| [1, 2, 3], | ||
| ], | ||
| [ | ||
| ["a", "b", "c"], | ||
| ["b", "c", "d"], | ||
| ["b", "c"], | ||
| ], | ||
| ])( | ||
| "intersect(%o, %o, %o)", | ||
| async ( | ||
| /** @type {(string|number)[]} */ a, | ||
| /** @type {(string|number)[]} */ b, | ||
| /** @type {(string|number)[]} */ result, | ||
| ) => { | ||
| const setA = new Set(a); | ||
| const setB = new Set(b); | ||
| const setResult = new Set(result); | ||
|
|
||
| // Check both orders, result should be same | ||
| expect(intersect(setA, setB)).toEqual(setResult); | ||
| expect(intersect(setB, setA)).toEqual(setResult); | ||
| }, | ||
| ); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| // @ts-check | ||
|
|
||
| /** | ||
| * @param {import('@actions/github-script').AsyncFunctionArguments} AsyncFunctionArguments | ||
| * @returns {Promise<void>} | ||
| */ | ||
| export default async function dumpTriggerMetadata({ context, core }) { | ||
| core.info(`Event name: ${context.eventName}`); | ||
| core.info(`Action: ${context.payload.action}`); | ||
|
|
||
| if ( | ||
| context.eventName === "workflow_run" && | ||
| context.payload.action === "completed" && | ||
scbedd marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| context.payload.workflow_run | ||
| ) { | ||
| const payload = /** @type {import("@octokit/webhooks-types").WorkflowRunCompletedEvent} */ ( | ||
|
|
||
| context.payload | ||
| ); | ||
|
|
||
| const run = payload.workflow_run; | ||
| core.info(`Triggering workflow: ${run.name}`); | ||
| core.info(`Triggering workflow ID: ${run.id}`); | ||
| core.info(`Triggering run ID: ${run.run_number}`); | ||
| core.info(`Triggering event: ${run.event}`); | ||
| core.info(`Triggering status: ${run.status}`); | ||
| core.info(`Triggering conclusion: ${run.conclusion}`); | ||
| core.info(`Triggering branch: ${run.head_branch}`); | ||
| core.info(`Triggering SHA: ${run.head_sha}`); | ||
| core.info(`Triggering actor: ${run.actor?.login || "unknown"}`); | ||
|
|
||
| // Create clickable URL to the triggering workflow run | ||
| const triggeringRunUrl = `https://github.com/${context.repo.owner}/${context.repo.repo}/actions/runs/${run.id}`; | ||
| core.info(`🔗 Triggering workflow run URL: ${triggeringRunUrl}`); | ||
|
|
||
| // If there's a pull request associated, show that too | ||
| if (run.pull_requests && run.pull_requests.length > 0) { | ||
| run.pull_requests.forEach((pr) => { | ||
| const prUrl = `https://github.com/${context.repo.owner}/${context.repo.repo}/pull/${pr.number}`; | ||
| core.info(`🔗 Associated PR: ${prUrl}`); | ||
| }); | ||
| } | ||
| } else if (context.eventName === "pull_request_target" && context.payload.pull_request) { | ||
| const payload = /** @type {import("@octokit/webhooks-types").PullRequestEvent} */ ( | ||
|
|
||
| context.payload | ||
| ); | ||
|
|
||
| const pr = payload.pull_request; | ||
| core.info(`PR number: ${pr.number}`); | ||
| core.info(`PR title: ${pr.title}`); | ||
| core.info(`PR state: ${pr.state}`); | ||
| core.info(`PR head SHA: ${pr.head.sha}`); | ||
| core.info(`PR base branch: ${pr.base.ref}`); | ||
| core.info(`🔗 PR URL: ${pr.html_url}`); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved from summarize-checks.yaml mostly unchanged. I prefer scripts over a few lines in a separate JS file, for editing ergonomics if nothing else.