[Datafactory] Adding new API to get GitHub access token #3827

hvermis · 2018-09-07T01:12:12Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-09-07T01:13:50Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2293

AutorestCI · 2018-09-07T01:26:09Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

azuresdkci · 2018-09-07T01:31:02Z

Can one of the admins verify this patch?

AutorestCI · 2018-09-07T01:53:48Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2630

AutorestCI · 2018-09-07T02:00:33Z

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

AutorestCI · 2018-09-07T02:16:43Z

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2136

hovsepm · 2018-09-07T16:56:27Z

...cation/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json

+      "description": "Get GitHub access token response definition.",
+      "properties": {
+        "gitHubAccessToken": {
+          "description": "GitHub access token.",


"readOnly": true ? #Resolved

hovsepm · 2018-09-07T16:58:37Z

error: 
operationId: Factories_GetGitHubAccessToken
scenario: Factories_GetGitHubAccessToken
source: response
responseCode: '200'
severity: 0
errorCode: OBJECT_ADDITIONAL_PROPERTIES
errorDetails:
  code: OBJECT_ADDITIONAL_PROPERTIES
  params:
    - - tags
      - location
      - eTag
      - properties
      - type
      - name
      - id
  message: >-
    Additional properties not allowed:
    tags,location,eTag,properties,type,name,id
  path: ''
  title: /definitions/GitHubAccessTokenResponse
  description: Get GitHub access token response definition.
  position:
    line: 3252
    column: 34
  url: >-
    specification/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json
  jsonPosition: !<tag:yaml.org,2002:js/undefined> ''
  jsonUrl: >-
    specification/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/examples/Factories_GetGitHubAccessToken.json

Seems like example does not return the type that is described in the swagger. Please fix. #Resolved

hovsepm · 2018-09-07T16:59:52Z

@hvermis there are bunch of existing Model Validator Errors not related to your PR. Please fix them in the future ;)
#Pending

hovsepm

waiting for example response message fix.

simongdavies · 2018-09-07T18:15:50Z

...cation/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json

        }
      }
    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataFactory/factories/{factoryName}/getGitHubAccessToken": {


Do you expect this action to be used in an ARM template? If so you may want to change the name so it begins with list, if you do this the action will be able to be invoked from a template , you also need to make changes to your manifest to enable this functionality as there is data in the POST body. #Closed

No, this will not be used in ARM templates. #Closed

hvermis · 2018-09-07T18:45:12Z

Will address them in next PR

In reply to: 419502847 [](ancestors = 419502847)

hvermis and others added 5 commits July 24, 2018 12:15

[ADF] Bringing back additionalProperties in Activity removed by mistake

04d330d

Merge branch 'master' of https://github.com/azure/azure-rest-api-specs

3cf350f

add github token api and exposure control api

9ad17fb

Removing Exposure Control API for now.

79922b3

Removing the example for ExposureControl API

e2194ea

AutorestCI mentioned this pull request Sep 7, 2018

[AutoPR datafactory/resource-manager] [Datafactory] Adding new API to get GitHub access token Azure/azure-sdk-for-python#3290

Merged

azuresdkci assigned hovsepm Sep 7, 2018

azuresdkci requested a review from hovsepm September 7, 2018 01:34

AutorestCI mentioned this pull request Sep 7, 2018

[AutoPR datafactory/resource-manager] [Datafactory] Adding new API to get GitHub access token Azure/azure-sdk-for-go#2634

Merged

AutorestCI mentioned this pull request Sep 7, 2018

[AutoPR datafactory/resource-manager] [Datafactory] Adding new API to get GitHub access token Azure/azure-sdk-for-node#3528

Merged

AutorestCI mentioned this pull request Sep 7, 2018

[AutoPR datafactory/resource-manager] [Datafactory] Adding new API to get GitHub access token Azure/azure-sdk-for-java#2372

Merged

hovsepm reviewed Sep 7, 2018

View reviewed changes

hovsepm suggested changes Sep 7, 2018

View reviewed changes

simongdavies reviewed Sep 7, 2018

View reviewed changes

Fixed the example and made the response readonly

5b0984a

Removing readonly from access token

d0dbe4b

hovsepm approved these changes Sep 7, 2018

View reviewed changes

hovsepm merged commit 481e9b9 into Azure:master Sep 7, 2018

[Datafactory] Adding new API to get GitHub access token #3827

[Datafactory] Adding new API to get GitHub access token #3827

Uh oh!

Conversation

hvermis commented Sep 7, 2018

PR information

Quality of Swagger

Uh oh!

AutorestCI commented Sep 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Sep 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

azuresdkci commented Sep 7, 2018

Uh oh!

AutorestCI commented Sep 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

AutorestCI commented Sep 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Sep 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

hovsepm Sep 7, 2018 • edited by hvermis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hovsepm commented Sep 7, 2018 • edited by hvermis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hovsepm commented Sep 7, 2018 • edited by hvermis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hovsepm left a comment

Choose a reason for hiding this comment

Uh oh!

simongdavies Sep 7, 2018 • edited by hovsepm Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hvermis Sep 7, 2018 • edited by hovsepm Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hvermis commented Sep 7, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

AutorestCI commented Sep 7, 2018 •

edited

Loading

AutorestCI commented Sep 7, 2018 •

edited

Loading

AutorestCI commented Sep 7, 2018 •

edited

Loading

AutorestCI commented Sep 7, 2018 •

edited

Loading

AutorestCI commented Sep 7, 2018 •

edited

Loading

hovsepm Sep 7, 2018 •

edited by hvermis

Loading

hovsepm commented Sep 7, 2018 •

edited by hvermis

Loading

hovsepm commented Sep 7, 2018 •

edited by hvermis

Loading

simongdavies Sep 7, 2018 •

edited by hovsepm

Loading

hvermis Sep 7, 2018 •

edited by hovsepm

Loading