Skip to content

[Datafactory] Adding new API to get GitHub access token #3827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hovsepm merged 7 commits into from
Sep 7, 2018
Merged

[Datafactory] Adding new API to get GitHub access token #3827

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
04d330d
[ADF] Bringing back additionalProperties in Activity removed by mistake
hvermis Jul 24, 2018
3cf350f
Merge branch 'master' of https://github.com/azure/azure-rest-api-specs
hvermis Sep 7, 2018
9ad17fb
add github token api and exposure control api
Aug 17, 2018
79922b3
Removing Exposure Control API for now.
hvermis Sep 7, 2018
e2194ea
Removing the example for ExposureControl API
hvermis Sep 7, 2018
5b0984a
Fixed the example and made the response readonly
hvermis Sep 7, 2018
d0dbe4b
Removing readonly from access token
hvermis Sep 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add github token api and exposure control api
  • Loading branch information
@hvermis
Thang Nguyen authored and hvermis committed Sep 7, 2018
commit 9ad17fb3f79dea9deb77415585cdaa30d91910f9
156 changes: 156 additions & 0 deletions ...ion/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,108 @@
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataFactory/factories/{factoryName}/getGitHubAccessToken": {
Copy link
Member

@simongdavies simongdavies Sep 7, 2018 •
edited by hovsepm
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you expect this action to be used in an ARM template? If so you may want to change the name so it begins with list, if you do this the action will be able to be invoked from a template , you also need to make changes to your manifest to enable this functionality as there is data in the POST body. #Closed

Copy link
Contributor Author

@hvermis hvermis Sep 7, 2018 •
edited by hovsepm
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this will not be used in ARM templates. #Closed

"post": {
"tags": [
"factories"
],
"operationId": "Factories_GetGitHubAccessToken",
"x-ms-examples": {
"Factories_GetGitHubAccessToken": {
"$ref": "./examples/Factories_GetGitHubAccessToken.json"
}
},
"description": "Get GitHub Access Token",
"parameters": [
{
"$ref": "#/parameters/subscriptionId"
},
{
"$ref": "#/parameters/resourceGroupName"
},
{
"$ref": "#/parameters/factoryName"
},
{
"$ref": "#/parameters/api-version"
},
{
"name": "gitHubAccessTokenRequest",
"description": "Get GitHub access token request definition.",
"in": "body",
"required": true,
"schema": {
"$ref": "#/definitions/GitHubAccessTokenRequest"
}
}
],
"responses": {
"200": {
"description": "OK.",
"schema": {
"$ref": "#/definitions/GitHubAccessTokenResponse"
}
},
"default": {
"description": "An error response received from the Azure Data Factory service.",
"schema": {
"$ref": "#/definitions/CloudError"
}
}
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataFactory/factories/{factoryName}/getFeatureValue": {
"post": {
"tags": [
"factories"
],
"operationId": "Factories_GetFeatureValue",
"x-ms-examples": {
"Factories_GetFeatureValue": {
"$ref": "./examples/Factories_GetFeatureValue.json"
}
},
"description": "Get Feature Value",
"parameters": [
{
"$ref": "#/parameters/subscriptionId"
},
{
"$ref": "#/parameters/resourceGroupName"
},
{
"$ref": "#/parameters/factoryName"
},
{
"$ref": "#/parameters/api-version"
},
{
"name": "exposureControlRequest",
"description": "Get feature value request definition.",
"in": "body",
"required": true,
"schema": {
"$ref": "#/definitions/ExposureControlRequest"
}
}
],
"responses": {
"200": {
"description": "OK.",
"schema": {
"$ref": "#/definitions/ExposureControlResponse"
}
},
"default": {
"description": "An error response received from the Azure Data Factory service.",
"schema": {
"$ref": "#/definitions/CloudError"
}
}
}
}
},
"/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataFactory/factories/{factoryName}/integrationRuntimes": {
"get": {
"tags": [
Expand Down Expand Up @@ -3177,6 +3279,60 @@
}
}
},
"GitHubAccessTokenRequest": {
"description": "Get GitHub access token request definition.",
"properties": {
"gitHubAccessCode": {
"description": "GitHub access code.",
"type": "string"
},
"gitHubClientId": {
"description": "GitHub application client ID.",
"type": "string"
},
"gitHubAccessTokenBaseUrl": {
"description": "GitHub access token base URL.",
"type": "string"
}
},
"required": [
"gitHubAccessCode",
"gitHubAccessTokenBaseUrl"
]
},
"GitHubAccessTokenResponse": {
"description": "Get GitHub access token response definition.",
"properties": {
"gitHubAccessToken": {
"description": "GitHub access token.",
Copy link
Contributor

@hovsepm hovsepm Sep 7, 2018 •
edited by hvermis
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"readOnly": true ? #Resolved

"type": "string"
}
}
},
"ExposureControlRequest": {
"description": "Get feature value request definition.",
"properties": {
"featureName": {
"description": "Feature name.",
"type": "string"
}
},
"required": [
"featureName"
]
},
"ExposureControlResponse": {
"description": "Get feature value response definition.",
"properties": {
"value": {
"description": "Feature Value.",
"type": "string"
}
},
"required": [
"value"
]
},
"FactoryProperties": {
"description": "Factory resource properties.",
"properties": {
Expand Down
34 changes: 34 additions & 0 deletions ...e-manager/Microsoft.DataFactory/stable/2018-06-01/examples/Factories_GetFeatureValue.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
{
"parameters": {
"subscriptionId": "12345678-1234-1234-1234-12345678abc",
"resourceGroupName": "exampleResourceGroup",
"factoryName": "exampleFactoryName",
"exposureControlRequest": {
"featureName": "some"
},
"api-version": "2018-06-01"
},
"responses": {
"200": {
"headers": {
"Date": "Mon, 23 Jul 2018 17:04:45 GMT",
"X-Content-Type-Options": "nosniff",
"x-ms-ratelimit-remaining-subscription-reads": "14999",
"x-ms-request-id": "991aa7d9-ab27-4e0e-874c-5cf7bd4ef763",
"x-ms-correlation-request-id": "991aa7d9-ab27-4e0e-874c-5cf7bd4ef763"
},
"body": {
"id": "/subscriptions/12345678-1234-1234-1234-12345678abc/resourceGroups/exampleResourceGroup/providers/Microsoft.DataFactory/factories/exampleFactoryName",
"name": "exampleIntegrationRuntime",
"type": "Microsoft.DataFactory/factories",
"properties": {
"provisioningState":"Succeeded",
"createTime":"2018-07-03T19:07:55.5145009Z",
"version":"2018-06-01"
},
"eTag":"0000b055-0000-0000-0000-5b3bc9e70000",
"location":"eastus2euap"
}
}
}
}
37 changes: 37 additions & 0 deletions ...ager/Microsoft.DataFactory/stable/2018-06-01/examples/Factories_GetGitHubAccessToken.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
{
"parameters": {
"subscriptionId": "12345678-1234-1234-1234-12345678abc",
"resourceGroupName": "exampleResourceGroup",
"factoryName": "exampleFactoryName",
"gitHubAccessTokenRequest": {
"gitHubAccessCode": "some",
"gitHubClientId": "some",
"gitHubAccessTokenBaseUrl": "some"
},
"api-version": "2018-06-01"
},
"responses": {
"200": {
"headers": {
"Date": "Mon, 23 Jul 2018 17:04:45 GMT",
"X-Content-Type-Options": "nosniff",
"x-ms-ratelimit-remaining-subscription-reads": "14999",
"x-ms-request-id": "991aa7d9-ab27-4e0e-874c-5cf7bd4ef763",
"x-ms-correlation-request-id": "991aa7d9-ab27-4e0e-874c-5cf7bd4ef763"
},
"body": {
"id": "/subscriptions/12345678-1234-1234-1234-12345678abc/resourceGroups/exampleResourceGroup/providers/Microsoft.DataFactory/factories/exampleFactoryName",
"name": "exampleIntegrationRuntime",
"type": "Microsoft.DataFactory/factories",
"properties": {
"provisioningState":"Succeeded",
"createTime":"2018-07-03T19:07:55.5145009Z",
"version":"2018-06-01"
},
"eTag":"0000b055-0000-0000-0000-5b3bc9e70000",
"location":"eastus2euap",
"tags":{"__gitRepoUrl__":"https://github.com/test/azure_data_factory","__gitRepoRootFolder__":"/","__gitRepoCollaborationBranch__":"master"}
}
}
}
}