Skip to content

Conversation

@ChenxiJiang333
Copy link
Member

@ChenxiJiang333 ChenxiJiang333 commented Oct 23, 2025

fix python breaking for #37236

@github-actions
Copy link

github-actions bot commented Oct 23, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ Your PR has breaking changes in the generated SDK for JavaScript (label: BreakingChange-JavaScript-Sdk). Refer to step 3 in the PR workflow diagram.
  • ❌ Your PR has breaking changes in the generated SDK for Python (label: BreakingChange-Python-Sdk). Refer to step 3 in the PR workflow diagram.

Important checks have failed. As of today they are not blocking this PR, but in near future they may.
Addressing the following failures is highly recommended:
  • ⚠️ The check named SDK Validation Status has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide


Comment generated by summarize-checks workflow run.

@github-actions github-actions bot added the TypeSpec Authored with TypeSpec label Oct 23, 2025
@github-actions
Copy link

github-actions bot commented Oct 23, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
TypeSpec Microsoft.DataBoxEdge
JavaScript @azure/arm-databoxedge
Java com.azure.resourcemanager:azure-resourcemanager-databoxedge

@msyyc msyyc marked this pull request as ready for review October 23, 2025 02:24
@msyyc msyyc merged commit 2937bf1 into Azure:tsp-conversion-databoxedge Oct 23, 2025
46 of 52 checks passed
pshao25 added a commit that referenced this pull request Nov 10, 2025
* migrate once

* Fix error type for operations interface

* add readonly visibility for paging model value

* fix x-ms-secret

* update swagger

* update swagger

* Update cspell.yaml

* Revert "Update cspell.yaml"

This reverts commit 85cfcc9.

* update

* update

* update

* Delete databoxedge.json

* Update readme.md

* prettier

* Create client.tsp

* Update client.tsp

* update no properties resource model and summary

* update tspconfig

* Add Java SDK breaking change mitigations for TypeSpec migration

- Added clientName decorators to fix model name casing issues:
  - SSLStatus -> SslStatus
  - NetworkAdapterDHCPStatus -> NetworkAdapterDhcpStatus
  - NetworkAdapterRDMAStatus -> NetworkAdapterRdmaStatus
  - ARMBaseModel -> ArmBaseModel
- Fixed property name changes:
  - RefreshDetails.lastCompletedRefreshJobTimeInUTC -> lastCompletedRefreshJobTimeInUtc
  - StorageAccountCredentialProperties.userName -> username

* resolve js breaking

* mitigate reorder breakings (#38379)

* Update client.tsp

* add config (#38636)

* Add 'go' support to DataBoxEdge client overrides

Updated override annotations to include 'go' alongside 'python' for various methods in the DataBoxEdge client.

* format

* update

---------

Co-authored-by: Wenming Liu <[email protected]>
Co-authored-by: mcgallan <[email protected]>
Co-authored-by: mcgallan <[email protected]>
Co-authored-by: Weidong Xu <[email protected]>
Co-authored-by: Jiao Di (MSFT) <[email protected]>
Co-authored-by: ChenxiJiang333 <[email protected]>
Co-authored-by: zedy <[email protected]>
Co-authored-by: Judy Liu <[email protected]>
Co-authored-by: Chenjie Shi <[email protected]>
Co-authored-by: Pan Shao <[email protected]>
anushkasingh16 pushed a commit to anushkasingh16/azure-rest-api-specs that referenced this pull request Nov 11, 2025
* migrate once

* Fix error type for operations interface

* add readonly visibility for paging model value

* fix x-ms-secret

* update swagger

* update swagger

* Update cspell.yaml

* Revert "Update cspell.yaml"

This reverts commit 85cfcc9.

* update

* update

* update

* Delete databoxedge.json

* Update readme.md

* prettier

* Create client.tsp

* Update client.tsp

* update no properties resource model and summary

* update tspconfig

* Add Java SDK breaking change mitigations for TypeSpec migration

- Added clientName decorators to fix model name casing issues:
  - SSLStatus -> SslStatus
  - NetworkAdapterDHCPStatus -> NetworkAdapterDhcpStatus
  - NetworkAdapterRDMAStatus -> NetworkAdapterRdmaStatus
  - ARMBaseModel -> ArmBaseModel
- Fixed property name changes:
  - RefreshDetails.lastCompletedRefreshJobTimeInUTC -> lastCompletedRefreshJobTimeInUtc
  - StorageAccountCredentialProperties.userName -> username

* resolve js breaking

* mitigate reorder breakings (Azure#38379)

* Update client.tsp

* add config (Azure#38636)

* Add 'go' support to DataBoxEdge client overrides

Updated override annotations to include 'go' alongside 'python' for various methods in the DataBoxEdge client.

* format

* update

---------

Co-authored-by: Wenming Liu <[email protected]>
Co-authored-by: mcgallan <[email protected]>
Co-authored-by: mcgallan <[email protected]>
Co-authored-by: Weidong Xu <[email protected]>
Co-authored-by: Jiao Di (MSFT) <[email protected]>
Co-authored-by: ChenxiJiang333 <[email protected]>
Co-authored-by: zedy <[email protected]>
Co-authored-by: Judy Liu <[email protected]>
Co-authored-by: Chenjie Shi <[email protected]>
Co-authored-by: Pan Shao <[email protected]>
@ChenxiJiang333 ChenxiJiang333 deleted the pr-37236 branch November 14, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants