Skip to content

Conversation

@haolingdong-msft
Copy link
Member

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

@github-actions
Copy link

github-actions bot commented Sep 9, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

@github-actions github-actions bot added resource-manager TypeSpec Authored with TypeSpec labels Sep 9, 2025
@github-actions
Copy link

github-actions bot commented Sep 9, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
TypeSpec Microsoft.DataBoxEdge
Go sdk/resourcemanager/databoxedge/armdataboxedge
C# Azure.ResourceManager.DataBoxEdge
Java com.azure.resourcemanager:azure-resourcemanager-databoxedge
JavaScript @azure/arm-databoxedge
Swagger Microsoft.DataBoxEdge-DataBoxEdge
Python azure-mgmt-databoxedge

@github-actions github-actions bot added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Sep 10, 2025
jliusan and others added 2 commits November 7, 2025 15:29
Updated override annotations to include 'go' alongside 'python' for various methods in the DataBoxEdge client.
@pshao25 pshao25 added BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. Approved-LintDiff labels Nov 10, 2025
@github-actions github-actions bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels Nov 10, 2025
@pshao25 pshao25 added PublishToCustomers Acknowledgement the changes will be published to Azure customers. BreakingChange-Go-Sdk-Approved BreakingChange-JavaScript-Sdk-Approved BreakingChange-Python-Sdk-Approved ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Nov 10, 2025
@github-actions github-actions bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 10, 2025
@pshao25 pshao25 merged commit b1a968a into main Nov 10, 2025
39 of 41 checks passed
@pshao25 pshao25 deleted the tsp-conversion-databoxedge branch November 10, 2025 09:28
anushkasingh16 pushed a commit to anushkasingh16/azure-rest-api-specs that referenced this pull request Nov 11, 2025
* migrate once

* Fix error type for operations interface

* add readonly visibility for paging model value

* fix x-ms-secret

* update swagger

* update swagger

* Update cspell.yaml

* Revert "Update cspell.yaml"

This reverts commit 85cfcc9.

* update

* update

* update

* Delete databoxedge.json

* Update readme.md

* prettier

* Create client.tsp

* Update client.tsp

* update no properties resource model and summary

* update tspconfig

* Add Java SDK breaking change mitigations for TypeSpec migration

- Added clientName decorators to fix model name casing issues:
  - SSLStatus -> SslStatus
  - NetworkAdapterDHCPStatus -> NetworkAdapterDhcpStatus
  - NetworkAdapterRDMAStatus -> NetworkAdapterRdmaStatus
  - ARMBaseModel -> ArmBaseModel
- Fixed property name changes:
  - RefreshDetails.lastCompletedRefreshJobTimeInUTC -> lastCompletedRefreshJobTimeInUtc
  - StorageAccountCredentialProperties.userName -> username

* resolve js breaking

* mitigate reorder breakings (Azure#38379)

* Update client.tsp

* add config (Azure#38636)

* Add 'go' support to DataBoxEdge client overrides

Updated override annotations to include 'go' alongside 'python' for various methods in the DataBoxEdge client.

* format

* update

---------

Co-authored-by: Wenming Liu <[email protected]>
Co-authored-by: mcgallan <[email protected]>
Co-authored-by: mcgallan <[email protected]>
Co-authored-by: Weidong Xu <[email protected]>
Co-authored-by: Jiao Di (MSFT) <[email protected]>
Co-authored-by: ChenxiJiang333 <[email protected]>
Co-authored-by: zedy <[email protected]>
Co-authored-by: Judy Liu <[email protected]>
Co-authored-by: Chenjie Shi <[email protected]>
Co-authored-by: Pan Shao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-LintDiff ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. BreakingChange-Go-Sdk BreakingChange-Go-Sdk-Approved BreakingChange-JavaScript-Sdk BreakingChange-JavaScript-Sdk-Approved BreakingChange-Python-Sdk BreakingChange-Python-Sdk-Approved BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager TypeSpec Authored with TypeSpec

Projects

None yet

Development

Successfully merging this pull request may close these issues.