Adding JSON encoding type to storage endpoint

[aklintsevich]

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

• I have reviewed the documentation for the workflow.
• Validation tools were run on swagger spec(s) and have all been fixed in this PR.
• The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

• Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
• adding/removing APIs.
• adding/removing properties.
• adding/removing API-version.
• adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

• If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
  Please follow the link to find more details on API review process.

[openapi-portal-comment]

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

[AutorestCI]

Automation for azure-sdk-for-go

Encountered a Subprocess error: (azure-sdk-for-go)

Command: ['/usr/local/bin/autorest', '/tmp/tmplyu43iwa/rest/specification/iothub/resource-manager/readme.md', '--go', '--go-sdk-folder=/tmp/tmplyu43iwa/src/github.com/Azure/azure-sdk-for-go', '--multiapi', '--preview-chk', '[email protected]/autorest.go@~2.1.127', '--use-onever', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4289)
   Including configuration file 'file:///tmp/tmplyu43iwa/rest/specification/iothub/resource-manager/readme.go.md'
   Loading AutoRest extension '@microsoft.azure/autorest.go' (~2.1.127->2.1.127)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
Processing batch task - {"tag":"package-2018-12-preview"} .
   Including configuration file 'file:///tmp/tmplyu43iwa/rest/specification/iothub/resource-manager/readme.go.md'
FATAL: System.InvalidOperationException: codegen for preview swagger Microsoft.Devices/preview/2018-12-01-preview/iothub.json must be under a preview subdirectory
   at AutoRest.Go.CodeGeneratorGo.<Generate>d__6.MoveNext() in /home/vsts/work/1/s/src/CodeGeneratorGo.cs:line 51
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at AutoRest.Go.Program.<ProcessInternal>d__3.MoveNext() in /home/vsts/work/1/s/src/Program.cs:line 107
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at NewPlugin.<Process>d__20.MoveNext() in /home/vsts/work/1/s/autorest.common/src/Plugins/NewPlugin.cs:line 163
FATAL: go/generate - FAILED
FATAL: Error: Plugin go reported failure.
Process() cancelled due to exception : Plugin go reported failure.
Failure during batch task - {"tag":"package-2018-12-preview"} -- Error: Plugin go reported failure..
  Error: Plugin go reported failure.

[AutorestCI]

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#547

[AutorestCI]

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4084

[AutorestCI]

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2173

[AutorestCI]

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#4154

[AutorestCI]

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2347

[nschonni]

I guess the values described in the "Supported values are" should probably match the enum casing

[aklintsevich]

There are multiple instances where the values described in the "Supported values are" do no match the enum casing in the repo. Is this a requirement?

In addition, do you understand the failure for "Automatin for azure-sdk-for-go". - "FATAL: System.InvalidOperationException: codegen for preview swagger Microsoft.Devices/preview/2018-12-01-preview/iothub.json must be under a preview subdirectory"

My change is in a preview subdirectory. Would you know what I am missing? Should I create a subdirectory for this month and year?

[nschonni]

Sorry, I'm not an MS employee, I've just been trying to get some automated spellchecking landed 😉
I've seen some failures like that on my own PRs. Sometimes it's because the folder isn't created yet in the upstream repo (or something like that).
I'm sure one of the real admins can point you in the right direction though

[azuresdkci]

Can one of the admins verify this patch?