Skip to content

Adding JSON encoding type to storage endpoint #5069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jianghaolu merged 1 commit into from
Jan 22, 2019
Merged

Adding JSON encoding type to storage endpoint #5069

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ...fication/iothub/resource-manager/Microsoft.Devices/preview/2018-12-01-preview/iothub.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2386,8 +2386,13 @@
"minimum": 10485760
},
"encoding": {
"description": "Encoding that is used to serialize messages to blobs. Supported values are 'avro' and 'avrodeflate'. Default value is 'avro'.",
"type": "string"
"description": "Encoding that is used to serialize messages to blobs. Supported values are 'avro', 'avrodeflate', and 'JSON'. Default value is 'avro'.",
Copy link
Contributor

@nschonni nschonni Jan 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the values described in the "Supported values are" should probably match the enum casing

Copy link
Contributor Author

@aklintsevich aklintsevich Jan 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are multiple instances where the values described in the "Supported values are" do no match the enum casing in the repo. Is this a requirement?

In addition, do you understand the failure for "Automatin for azure-sdk-for-go". - "FATAL: System.InvalidOperationException: codegen for preview swagger Microsoft.Devices/preview/2018-12-01-preview/iothub.json must be under a preview subdirectory"

My change is in a preview subdirectory. Would you know what I am missing? Should I create a subdirectory for this month and year?

Copy link
Contributor

@nschonni nschonni Jan 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'm not an MS employee, I've just been trying to get some automated spellchecking landed 😉
I've seen some failures like that on my own PRs. Sometimes it's because the folder isn't created yet in the upstream repo (or something like that).
I'm sure one of the real admins can point you in the right direction though

"type": "string",
"enum": [
"Avro",
"AvroDeflate",
"JSON"
]
}
},
"required": [
Expand Down