[Hub Generated] Review request for Microsoft.Devices to add version 2019-03-12 #5404

jlian · 2019-03-15T21:16:18Z

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…01 to version 2019-03-12

AutorestCI · 2019-03-15T21:17:04Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 3264f30abeeb422804a0bf3e07b62d8898b76dda
  stderr: 'fatal: reference is not a tree: 3264f30abeeb422804a0bf3e07b62d8898b76dda'

AutorestCI · 2019-03-15T21:17:16Z

Automation for azure-sdk-for-js

Encountered an unknown error: (azure-sdk-for-js)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 3264f30abeeb422804a0bf3e07b62d8898b76dda
  stderr: 'fatal: reference is not a tree: 3264f30abeeb422804a0bf3e07b62d8898b76dda'

AutorestCI · 2019-03-15T21:17:46Z

Automation for azure-sdk-for-ruby

Encountered an unknown error: (azure-sdk-for-ruby)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 3264f30abeeb422804a0bf3e07b62d8898b76dda
  stderr: 'fatal: reference is not a tree: 3264f30abeeb422804a0bf3e07b62d8898b76dda'

AutorestCI · 2019-03-15T21:17:57Z

Automation for azure-sdk-for-node

A PR has been created for you:
Azure/azure-sdk-for-node#4938

AutorestCI · 2019-03-15T21:19:00Z

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 3264f30abeeb422804a0bf3e07b62d8898b76dda
  stderr: 'fatal: reference is not a tree: 3264f30abeeb422804a0bf3e07b62d8898b76dda'

AutorestCI · 2019-03-15T21:19:16Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 3264f30abeeb422804a0bf3e07b62d8898b76dda
  stderr: 'fatal: reference is not a tree: 3264f30abeeb422804a0bf3e07b62d8898b76dda'

azuresdkci · 2019-03-15T21:20:24Z

Can one of the admins verify this patch?

REST Spec PR 'Azure/azure-rest-api-specs#5404' REST Spec PR Author 'jlian' REST Spec PR Last commit

adxsdknet · 2019-03-15T21:23:49Z

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5478
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@0c60a91
adxsdknet/azure-sdk-for-net@ef3d3af
adxsdknet/azure-sdk-for-net@2f36249

dsgouda · 2019-03-18T16:39:57Z

...tion/iothub/resource-manager/Microsoft.Devices/stable/2019-03-12/examples/iothub_delete.json

+    "responses": {
+        "200": {
+            "body": {
+                "id": "/subscriptions/91d12660-3dec-467a-be2a-213b5544ddc0/resourceGroups/myResourceGroup/providers/Microsoft.Devices/IotHubs/testHub",


nit: its good practice to avoid using production style subscription ids

dsgouda · 2019-03-18T16:43:02Z

Looks good for the most part, just need a quick approval from ARM for the deleted models

jlian · 2019-03-18T17:59:49Z

Thanks. This means we have to meet with ARM team right?

dsgouda · 2019-03-18T18:09:02Z

@jlian ARM will post their comments on this PR, don't think you need to meet them since it is a relatively small change

jlian · 2019-03-18T18:15:01Z

Ok thanks. We're not ready for this to be merged into master yet (I'm preempting a little with this PR). Just want to make sure that we can get a heads up before the merge? Or is there a "hold-off" label like docs we can use?

dsgouda · 2019-03-18T18:17:11Z

I have added the DoNotMerge label

dsgouda · 2019-03-25T23:34:20Z

startbuild

dsgouda · 2019-03-26T17:35:33Z

startbuild

REST Spec PR 'Azure/azure-rest-api-specs#5404' REST Spec PR Author 'jlian' REST Spec PR Last commit

KrisBash

LGTM

dsgouda

LGTM

dsgouda · 2019-04-02T16:50:08Z

@jlian We are ready to merge this one. Please let us know when we can.

jlian · 2019-04-02T17:56:06Z

We're still getting ready on our side. Sorry for the delay

dsgouda · 2019-04-10T18:54:19Z

@jlian gentle reminder, we will close the PR by EOW if there is no activity

dsgouda · 2019-04-12T20:30:10Z

startbuild

REST Spec PR 'Azure/azure-rest-api-specs#5404' REST Spec PR Author 'jlian' REST Spec PR Last commit

jlian · 2019-04-13T00:54:35Z

Gonna close this until we can figure it out form our end

jlian and others added 5 commits March 15, 2019 14:07

Adds base for updating Microsoft.Devices from version stable/2018-04-…

0920f8b

…01 to version 2019-03-12

Updates readme

26646e7

Updates API version in new specs and examples

db0466a

Remove ops mon properties

07bc1e1

Remove mentions of operationsMonitoringEvents

2aac28e

azuresdkci assigned dsgouda Mar 15, 2019

azuresdkci requested a review from dsgouda March 15, 2019 21:16

AutorestCI mentioned this pull request Mar 15, 2019

[AutoPR iothub/resource-manager] [Hub Generated] Review request for Microsoft.Devices to add version 2019-03-12 Azure/azure-sdk-for-python#4591

Closed

AutorestCI mentioned this pull request Mar 15, 2019

[AutoPR iothub/resource-manager] [Hub Generated] Review request for Microsoft.Devices to add version 2019-03-12 Azure/azure-sdk-for-js#1603

Closed

AutorestCI mentioned this pull request Mar 15, 2019

[AutoPR iothub/resource-manager] [Hub Generated] Review request for Microsoft.Devices to add version 2019-03-12 Azure/azure-sdk-for-ruby#2332

Closed

AutorestCI mentioned this pull request Mar 15, 2019

[AutoPR iothub/resource-manager] [Hub Generated] Review request for Microsoft.Devices to add version 2019-03-12 Azure/azure-sdk-for-node#4938

Closed

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 15, 2019

.NET SDK Resource Provider:'IotHub'

0c60a91

REST Spec PR 'Azure/azure-rest-api-specs#5404' REST Spec PR Author 'jlian' REST Spec PR Last commit

dsgouda added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 18, 2019

dsgouda suggested changes Mar 18, 2019

View reviewed changes

dsgouda added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Mar 18, 2019

jlian mentioned this pull request Mar 20, 2019

[Hub Generated] Review request for Microsoft.Devices to change version 2018-12-01-preview #5405

Merged

2 tasks

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 26, 2019

.NET SDK Resource Provider:'IotHub'

ef3d3af

REST Spec PR 'Azure/azure-rest-api-specs#5404' REST Spec PR Author 'jlian' REST Spec PR Last commit

KrisBash approved these changes Apr 2, 2019

View reviewed changes

KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Apr 2, 2019

dsgouda approved these changes Apr 2, 2019

View reviewed changes

dsgouda mentioned this pull request Apr 3, 2019

AutoPr-IotHub-jlian-REST Spec PrNumber 5404 Azure/azure-sdk-for-net#5594

Closed

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Apr 12, 2019

.NET SDK Resource Provider:'IotHub'

2f36249

REST Spec PR 'Azure/azure-rest-api-specs#5404' REST Spec PR Author 'jlian' REST Spec PR Last commit

jlian closed this Apr 13, 2019

[Hub Generated] Review request for Microsoft.Devices to add version 2019-03-12 #5404

[Hub Generated] Review request for Microsoft.Devices to add version 2019-03-12 #5404

Uh oh!

Conversation

jlian commented Mar 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution checklist:

Uh oh!

AutorestCI commented Mar 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Mar 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented Mar 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Mar 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented Mar 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented Mar 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

azuresdkci commented Mar 15, 2019

Uh oh!

adxsdknet commented Mar 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-net

Uh oh!

dsgouda Mar 18, 2019

Choose a reason for hiding this comment

Uh oh!

dsgouda commented Mar 18, 2019

Uh oh!

jlian commented Mar 18, 2019

Uh oh!

dsgouda commented Mar 18, 2019

Uh oh!

jlian commented Mar 18, 2019

Uh oh!

dsgouda commented Mar 18, 2019

Uh oh!

dsgouda commented Mar 25, 2019

Uh oh!

dsgouda commented Mar 26, 2019

Uh oh!

KrisBash left a comment

Choose a reason for hiding this comment

Uh oh!

dsgouda left a comment

Choose a reason for hiding this comment

Uh oh!

dsgouda commented Apr 2, 2019

Uh oh!

jlian commented Apr 2, 2019

Uh oh!

dsgouda commented Apr 10, 2019

Uh oh!

dsgouda commented Apr 12, 2019

Uh oh!

jlian commented Apr 13, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jlian commented Mar 15, 2019 •

edited

Loading

AutorestCI commented Mar 15, 2019 •

edited

Loading

AutorestCI commented Mar 15, 2019 •

edited

Loading

AutorestCI commented Mar 15, 2019 •

edited

Loading

AutorestCI commented Mar 15, 2019 •

edited

Loading

AutorestCI commented Mar 15, 2019 •

edited

Loading

AutorestCI commented Mar 15, 2019 •

edited

Loading

adxsdknet commented Mar 15, 2019 •

edited

Loading