Skip to content

[Hub Generated] Review request for Microsoft.Devices to change version 2018-12-01-preview #5405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sergey-shandar merged 1 commit into from
Mar 19, 2019
Merged

[Hub Generated] Review request for Microsoft.Devices to change version 2018-12-01-preview #5405

sergey-shandar merged 1 commit into from
Mar 19, 2019

Conversation

@jlian
Copy link
Member

@jlian jlian commented Mar 15, 2019 •
edited
Loading

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

@jlian jlian changed the title [Hub Generated] Review request for Microsoft.Devices to add version 2018-12-01-preview [Hub Generated] Review request for Microsoft.Devices to change version 2018-12-01-preview Mar 15, 2019
@AutorestCI AutorestCI mentioned this pull request Mar 15, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Mar 15, 2019 •
edited
Loading

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#1639

@AutorestCI AutorestCI mentioned this pull request Mar 15, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 15, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4084

@AutorestCI AutorestCI mentioned this pull request Mar 15, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 15, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2173

@AutorestCI AutorestCI mentioned this pull request Mar 15, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Mar 15, 2019 •
edited
Loading

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#4966

@azuresdkci
Copy link
Contributor

azuresdkci commented Mar 15, 2019

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Mar 15, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 15, 2019 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#3115

@AutorestCI AutorestCI mentioned this pull request Mar 15, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 15, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4321

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 15, 2019
@adxsdknet
.NET SDK Resource Provider:'IotHub'
f13ef06 
REST Spec PR 'Azure/azure-rest-api-specs#5405'
REST Spec PR Author 'jlian'
REST Spec PR Last commit
@adxsdknet
Copy link

adxsdknet commented Mar 15, 2019

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5479
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@f13ef06

@sergey-shandar sergey-shandar merged commit 47e3eb9 into Azure:master Mar 19, 2019
This was referenced Mar 19, 2019
Merged
Merged
dsgouda pushed a commit to Azure/azure-sdk-for-net that referenced this pull request Mar 19, 2019
@adxsdknet @dsgouda
.NET SDK Resource Provider:'IotHub' (#5479)
0510cc9 
REST Spec PR 'Azure/azure-rest-api-specs#5405'
REST Spec PR Author 'jlian'
REST Spec PR Last commit
@jlian
Copy link
Member Author

jlian commented Mar 20, 2019 •
edited
Loading

Hello ARM team and @sergey-shandar. Super sorry, but we're not ready to have this PR merged yet! Can we please revert if possible?

This is entirely my fault. I meant to mention that we're not yet ready in this PR (like I did in #5404), but forgot.

For future though, I think it might make sense to block the merge until the traffic validation passes.

image

@jlian
Copy link
Member Author

jlian commented Mar 20, 2019

Actually, we can do the revert PR ourselves. @sergey-shandar please ignore the previous comment

chidozieononiwu pushed a commit to chidozieononiwu/azure-sdk-for-net that referenced this pull request Mar 26, 2019
@adxsdknet @chidozieononiwu
.NET SDK Resource Provider:'IotHub' (Azure#5479)
c896f21 
REST Spec PR 'Azure/azure-rest-api-specs#5405'
REST Spec PR Author 'jlian'
REST Spec PR Last commit
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
@adxsdknet @mentat9
.NET SDK Resource Provider:'IotHub' (Azure#5479)
d0dbcdd 
REST Spec PR 'Azure/azure-rest-api-specs#5405'
REST Spec PR Author 'jlian'
REST Spec PR Last commit
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
@pan-wang
Add enable metrics support flag (#5405)
4dcfbba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sergey-shandar sergey-shandar sergey-shandar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sergey-shandar sergey-shandar

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jlian @AutorestCI @azuresdkci @adxsdknet @sergey-shandar