Remove the use of ifdef for TESTING_BUILD in KeyVault clients, where they are not needed. #5406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
they are not needed.
ahsonkhan
requested review from
LarryOsterman,
RickWinter,
antkmsft and
gearama
as code owners
antkmsft
added a commit
to antkmsft/azure-sdk-for-cpp
that referenced
this pull request
Mar 7, 2024
…, where (Azure#5406)" This reverts commit 2d8c940.
antkmsft
added a commit
that referenced
this pull request
Mar 7, 2024
…R_TESTS` (#5416) * Revert "Remove the use of ifdef for TESTING_BUILD in KeyVault clients, where (#5406)" This reverts commit 2d8c940. * Revert "Rename the TESTING_BUILD macro to be _azure_TESTING_BUILD to highlight (#5390)" This reverts commit 256c2df. * Revert "Use new macros in existing surface area, so that classes marked as final don't have virtual methods. (#5389)" This reverts commit 3d7eadd. * Revert "For new surface area, classes marked as final should not have virtual methods. (#5331)" This reverts commit ddd0f4b. --------- Co-authored-by: Anton Kolesnyk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KeyClientis the only one that needs to be conditionally marked as final sinceKeyClientWithNoAuthenticationPolicyinherits from it in tests. The other clients can be marked final, out-right.azure-sdk-for-cpp/sdk/keyvault/azure-security-keyvault-keys/test/ut/mocked_transport_adapter_test.hpp
Lines 109 to 112 in 61f5ce0