Revert commits related to _azure_BUILD_FOR_TESTING and _azure_*_FOR_TESTS
#5416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, where (Azure#5406)" This reverts commit 2d8c940.
…highlight (Azure#5390)" This reverts commit 256c2df.
…ed as final don't have virtual methods. (Azure#5389)" This reverts commit 3d7eadd.
… virtual methods. (Azure#5331)" This reverts commit ddd0f4b.
Member
Author
|
/azp run cpp - core |
Member
Author
|
/azp run cpp - attestation |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run cpp - storage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run cpp - identity |
Member
Author
|
/azp run cpp - keyvault |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run cpp - tables |
|
Azure Pipelines successfully started running 1 pipeline(s). |
antkmsft
requested review from
a team,
LarryOsterman,
RickWinter,
ahsonkhan,
gearama and
schaabs
as code owners
antkmsft
requested review from
KarishmaGhiya,
billwert,
maorleger and
mpodwysocki
ahsonkhan
reviewed
Mar 7, 2024
sdk/keyvault/azure-security-keyvault-secrets/inc/azure/keyvault/secrets/secret_client.hpp
Show resolved
Hide resolved
LarryOsterman
approved these changes
Mar 7, 2024
Member
LarryOsterman
left a comment
LarryOsterman
left a comment
There was a problem hiding this comment.
We should probably mark the changes we want to keep (like the AzureDoxygen.cmake changes).
Member
Author
|
@ahsonkhan, @LarryOsterman - I enumerated all things in this PR description, please comment if you think we should capture more. |
ahsonkhan
approved these changes
Mar 7, 2024
Contributor
ahsonkhan
left a comment
ahsonkhan
left a comment
There was a problem hiding this comment.
I will try to bring most things back other than the conditional virtual. Other than that, the rest of it was improvements we'd want, imo.
Given a revert like this is cleaner, approving.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encourage @ahsonkhan to re-apply some parts of it as soon as possible.
In my opinion, these were the good things:
Renaming
TESTING_BUILDto_azure_TESTING_BUILD. We can solve this by addingif(BUILD_TESTING) add_compile_definitions(_azure_TESTING_BUILD)in a centralized location, such asAzureGlobalCompileOptions.cmake/AddGoogleTest.cmake(or make a newcmakefile). Also, the existing#if defined/ #ifdef(_azure_TESTING_BUILD_AMQP)can be switched to#if defined(_azure_TESTING_BUILD)after that.All libraries having
_azure_TESTING_BUILDdefined when building the tests (Update remaining package CMakeLists.txt to include the_azure_TESTING_BUILDcompile definitions. #5414). If Item 1 above is done in a centralizedway, i.e. via
.cmakefile, this item should be automatically taken care of as well.Some testing
protecteds can be madeprivateunconditionally.For later:
Maybe drop "ifndef TESTING final". // BTW, for
test_hooks.hpp, should you end up creating one, I think,testing.hppwould be even better name, because the name implies we may put more testing-related stuff there in the future, the name is more generic.Maybe find a way to still drop
virtualandfinalfrom Doxygen; maybe from ApiView.Maybe think of the mocking support / exposing internal details or test hooks in another way / avoiding (so many) friend declarations (Think about good and consistent pattern for exposing some internal class details for unit tests #5147), and applying that pattern universally.