Skip to content

Conversation

@weidongxu-microsoft
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft commented Jun 24, 2024

regen from Azure/azure-rest-api-specs#29534

Previous regen didn't cover all instances of this maxpagesize change.

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Jun 24, 2024
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure.resourcemanager:azure-resourcemanager-storage

@weidongxu-microsoft
Copy link
Member Author

I cannot get through the error
https://dev.azure.com/azure-sdk/public/_build/results?buildId=3898434&view=logs&j=08302e96-a521-55ec-4878-06d3e3995667&t=3fab0f3b-8042-51d0-0456-b1f18b054d77&l=304

The change is for new code, that should not affect any lib other than resourcemanager.

@weidongxu-microsoft
Copy link
Member Author

/check-enforcer override

@weidongxu-microsoft weidongxu-microsoft marked this pull request as ready for review June 24, 2024 03:22
@weidongxu-microsoft weidongxu-microsoft merged commit 4fd50c5 into Azure:main Jun 24, 2024
@weidongxu-microsoft weidongxu-microsoft deleted the mgmt_storage-regen-from-29534 branch June 24, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management-plane library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants