-
Notifications
You must be signed in to change notification settings - Fork 5.6k
[StorageTasks] Bugfix maxpagesize type #29534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[StorageTasks] Bugfix maxpagesize type #29534
Conversation
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Validation Report
|
| Compared specs (v0.10.9) | new version | base version |
|---|---|---|
| storageTaskAssignments.json | 2023-05-01(b587b34) | 2023-05-01(main) |
| storageactions.json | 2023-01-01(b587b34) | 2023-01-01(main) |
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| Compared specs (v2.2.2) | new version | base version |
|---|---|---|
| package-2023-05 | package-2023-05(b587b34) | package-2023-05(main) |
| package-2023-01-01 | package-2023-01-01(b587b34) | package-2023-01-01(main) |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
PutResponseCodes |
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L56 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not be required, property:type. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L234 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not be required, property:enabled. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L234 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not be required, property:description. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L234 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not be required, property:action. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L234 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not be required, property:if. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L234 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not be required, property:condition. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L234 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not be required, property:operations. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L234 |
AvoidAdditionalProperties |
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L696 |
| The response of operation:'StorageTaskAssignments_Create' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Storage/stable/2023-05-01/storageTaskAssignments.json#L20 |
|
| The response of operation:'StorageTaskAssignments_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Storage/stable/2023-05-01/storageTaskAssignments.json#L93 |
|
| The response of operation:'StorageTaskAssignments_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Storage/stable/2023-05-01/storageTaskAssignments.json#L157 |
|
| A nested resource type's List operation must include all the parent segments in its api path. Location: Microsoft.Storage/stable/2023-05-01/storageTaskAssignments.json#L253 |
|
| A nested resource type's List operation must include all the parent segments in its api path. Location: Microsoft.Storage/stable/2023-05-01/storageTaskAssignments.json#L305 |
|
| Use the latest version v5 of types.json. Location: Microsoft.Storage/stable/2023-05-01/storageTaskAssignments.json#L436 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Storage/stable/2023-05-01/storageTaskAssignments.json#L452 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.Storage/stable/2023-05-01/storageTaskAssignments.json#L632 |
|
| OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'StorageTaskAssignmentModel'. Consider using the plural form of 'StorageTaskAssignment' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L360 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: ListStorageTasksByResourceGroup Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L414 |
|
| Not using the common-types defined parameter 'location'. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L485 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L576 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.StorageActions/stable/2023-01-01/storageactions.json#L983 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
|
/azp run |
|
Commenter does not have sufficient privileges for PR 29534 in repo Azure/azure-rest-api-specs |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
blueww
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a swagger only fix. Server already works with maxpagesize as integer.
|
https://github.com/Azure/sdk-release-request/issues/5261 is waiting for this PR |
|
I see that the $maxpagesize is still of type string in blob.json, file.json, queue.json. Shouldnt you modify also the type there? |
Thanks @razvanbadea-msft for the review! |
|
Would you please help to look at the swagger PR? This is a swagger only fix (no server change), and PSH/CLI/SDK release are blocked for this fix. |
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.