[Key Vault Admin] Convenience layer - KeyVaultAccessControlClient #10815
forgot to api extract the last commit
- Loading branch information
commit 0ce383e9ecf53989d8e9f9e468d2cd213fb6b7b7
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,7 +13,7 @@ export class AccessControlClient { | |
| constructor(vaultUrl: string, credential: TokenCredential, pipelineOptions?: AccessControlClientOptions); | ||
| createRoleAssignment(scope: RoleAssignmentScope, name: string, options?: CreateRoleAssignmentOptions): Promise<KeyVaultRoleAssignment>; | ||
sadasant marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| deleteRoleAssignment(scope: RoleAssignmentScope, name: string, options?: DeleteRoleAssignmentOptions): Promise<KeyVaultRoleAssignment>; | ||
| getRoleAssignment(scope: RoleAssignmentScope, name: string, options?: GetRoleAssignmentOptions): Promise<KeyVaultRoleAssignment>; | ||
| listRoleAssignments(scope: RoleAssignmentScope, options?: ListRoleAssignmentsOptions): PagedAsyncIterableIterator<KeyVaultRoleAssignment>; | ||
| listRoleDefinitions(scope: RoleAssignmentScope, options?: ListRoleDefinitionsOptions): PagedAsyncIterableIterator<KeyVaultRoleDefinition>; | ||
| readonly vaultUrl: string; | ||
|
|
@@ -33,6 +33,10 @@ export interface CreateRoleAssignmentOptions extends coreHttp.OperationOptions { | |
| export interface DeleteRoleAssignmentOptions extends coreHttp.OperationOptions { | ||
| } | ||
|
|
||
| // @public | ||
| export interface GetRoleAssignmentOptions extends coreHttp.OperationOptions { | ||
| } | ||
|
|
||
| // @public | ||
| export interface KeyVaultRoleAssignment { | ||
|
Contributor
Author
There was a problem hiding this comment. Before I do this change, let's argue about prefixes here: #10815 (comment)
Contributor
Author
There was a problem hiding this comment. @heaths I'm assuming KeyVaultRoleAssignment is favored after that conversation I mentioned ^ |
||
| readonly id?: string; | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per discussion below, the principalId and roleDefinitionId (?) should be parameters. Same goes for any required parameters in other methods that follow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated this by this point, to be:
Note that I used
roleDefinitionIdfirst, thenprincipalId, since I believe that the former one has a smaller scope than the later one, so I'm trying to go from micro to macro, scope-wise. Does this make sense? I can change it, I won't push back, but this is my argument for my current approach.Wait, what other methods have these as the required parameters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only methods that have these properties in .Net are: CreateRoleAssignment, and CreateRoleAssignmentAsync.