-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Key Vault Admin] Convenience layer - KeyVaultAccessControlClient #10815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sadasant
merged 37 commits into
Azure:master
from
sadasant:keyvault-admin/10799-convenience-layer
Sep 4, 2020
+910
−12
Merged
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
7c3cfc5
constructor and some of the surrounding things
sadasant 28b4eb6
createRoleAssignment
sadasant eb9cbe0
createRoleAssignment documentation
sadasant a5524f5
deleteRoleAssignment
sadasant 167935d
getRoleAssignment
sadasant 44e9eb3
listRoleAssignments
sadasant 3790bd1
listRoleDefinitions
sadasant 2188a87
api-extractor
sadasant 60f4bd3
formatting
sadasant ac414c9
deleted the filter option on the list operations
sadasant 9e5505a
fixing the build
sadasant 57fd102
lint fixes
sadasant 0ce383e
forgot to api extract the last commit
sadasant 7f179ef
bad reference to a parameter
sadasant 8919a93
Resolves https://github.com/Azure/azure-sdk-for-js/pull/10815#discuss…
sadasant ee1d71e
Addressing: https://github.com/Azure/azure-sdk-for-js/pull/10815#disc…
sadasant b7d3bf5
Feedback fixes
sadasant 26e9583
role to roleScope, and RoleDefinitionPermission to KeyVaultPermission
sadasant a10a592
KeyVaultAccessControlClient documentation and removing lint from the …
sadasant 09148fd
cleaned up bad reference to KeyClient
sadasant 1b0f642
Addressing https://github.com/Azure/azure-sdk-for-js/pull/10815#discu…
sadasant 4513d72
Merge remote-tracking branch 'Azure/master' into keyvault-admin/10799…
sadasant 6ab4ae1
fixed bad references
sadasant 7c845ca
Update sdk/keyvault/keyvault-admin/src/accessControlClient.ts
sadasant 9030441
Apply suggestions from code review
sadasant 18d7911
Fixes after updating from remote
sadasant 74b7bfc
Addressing https://github.com/Azure/azure-sdk-for-js/pull/10815/files…
sadasant ca12be4
tsdoc cleanup
sadasant e306ff4
linting
sadasant d61f0b6
Merge remote-tracking branch 'Azure/master' into keyvault-admin/10799…
sadasant 64a5d1d
fixes after updating the generated files
sadasant 1386365
enforcing most of the properties, after discussing with .Net
sadasant 590a835
Addressing https://github.com/Azure/azure-sdk-for-js/pull/10815#discu…
sadasant 23431cc
no more operationOptionsToRequestOptionsBase
sadasant 66bcdd4
Key Vault
sadasant 8484177
Merge remote-tracking branch 'Azure/master' into keyvault-admin/10799…
sadasant 24380a7
only 7.2-preview service version
sadasant File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Apply suggestions from code review
Co-authored-by: Jeff Fisher <xirzec@xirzec.com>
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.