Skip to content

Use common OIDC token env vars for live tests. #31335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
benbp wants to merge 3 commits into from
Closed

Use common OIDC token env vars for live tests. #31335

benbp wants to merge 3 commits into from

Conversation

@benbp
Copy link
Member

@benbp benbp commented Oct 8, 2024

Support oidc az cli login in post deploy scripts for multi-cloud. Requires Azure/azure-sdk-tools#9099

@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Oct 8, 2024
@benbp benbp requested review from a team, maorleger and schaabs as code owners October 8, 2024 17:26
@benbp benbp self-assigned this Oct 8, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 8, 2024

API change check

API changes are not detected in this pull request.

@benbp
Copy link
Member Author

benbp commented Oct 8, 2024

/azp run js - identity - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 8, 2024

Azure Pipelines failed to run 1 pipeline(s).

@benbp benbp mentioned this pull request Oct 8, 2024
Merged
@benbp benbp force-pushed the benbp/pre-steps-multi-cloud branch from da71231 to e8fa4a8 Compare October 8, 2024 19:38
@benbp
Copy link
Member Author

benbp commented Oct 8, 2024

/azp run js - identity - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 8, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@benbp
Copy link
Member Author

benbp commented Oct 8, 2024

/azp run js - identity - tests-weekly

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 8, 2024

Azure Pipelines successfully started running 1 pipeline(s).

weshaggard
weshaggard reviewed Oct 9, 2024
View reviewed changes
@benbp
Copy link
Member Author

benbp commented Oct 9, 2024

/azp run js - identity - tests-weekly

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 9, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@benbp benbp force-pushed the benbp/pre-steps-multi-cloud branch from da45805 to e316d64 Compare October 18, 2024 15:52
@benbp benbp force-pushed the benbp/pre-steps-multi-cloud branch from e316d64 to 4105a67 Compare October 18, 2024 15:52
@weshaggard weshaggard mentioned this pull request Oct 28, 2024
Merged
@maorleger maorleger mentioned this pull request Nov 18, 2024
Merged
3 tasks
@pvaneck pvaneck mentioned this pull request Nov 21, 2024
Merged
@benbp benbp requested a review from minhanh-phan as a code owner December 12, 2024 22:26
@benbp
Copy link
Member Author

benbp commented Dec 12, 2024

/azp run js - identity - tests-weekly

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 12, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@github-actions
Copy link

github-actions bot commented Feb 14, 2025

Hi @benbp. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Feb 14, 2025
@github-actions
Copy link

github-actions bot commented Feb 21, 2025

Hi @benbp. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

@github-actions github-actions bot closed this Feb 21, 2025
@maorleger maorleger mentioned this pull request Mar 10, 2025
Merged
maorleger added a commit that referenced this pull request Mar 10, 2025
@maorleger
[engSys] Use common OIDC token env vars for live tests (#33320)
7df8e99 
### Packages impacted by this PR

`@azure/identity`
`@azure/keyvault-admin`
`@azure/keyvault-keys`

### Issues associated with this PR


### Describe the problem that is addressed by this PR

Builds on previous work in
#31335
This PR adds support for `PersistOidcToken` parameter passing, allowing
one to
refresh their credential using `Connect-AzAccount` or `az login`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weshaggard weshaggard weshaggard approved these changes

@ckairen ckairen Awaiting requested review from ckairen

@mikeharder mikeharder Awaiting requested review from mikeharder mikeharder is a code owner

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya KarishmaGhiya is a code owner

@maorleger maorleger Awaiting requested review from maorleger maorleger is a code owner

@schaabs schaabs Awaiting requested review from schaabs

@joshfree joshfree Awaiting requested review from joshfree joshfree is a code owner automatically assigned from Azure/azure-sdk-write-identity

@g2vinay g2vinay Awaiting requested review from g2vinay g2vinay is a code owner automatically assigned from Azure/azure-sdk-write-identity

@chlowell chlowell Awaiting requested review from chlowell chlowell is a code owner automatically assigned from Azure/azure-sdk-write-identity

@mpodwysocki mpodwysocki Awaiting requested review from mpodwysocki mpodwysocki is a code owner automatically assigned from Azure/azure-sdk-write-identity

@minhanh-phan minhanh-phan Awaiting requested review from minhanh-phan minhanh-phan is a code owner

Assignees

@benbp benbp

Labels

Central-EngSys This issue is owned by the Engineering System team. no-recent-activity There has been no recent activity on this issue.

Projects

Azure SDK EngSys 📆🎇
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@benbp @azure-sdk @weshaggard