[engSys] Use common OIDC token env vars for live tests #33320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to Untriaged
in Azure Identity SDK Improvements
Member
Author
|
/azp run js - identity - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run js - keyvault-admin - tests-weekly |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
API change check API changes are not detected in this pull request. |
Member
Author
|
KeyVault Admin Managed HSM successfully deployed after this change: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4635988, test failures are related to test pollution and unrelated to this PR Identity deployment succeeds as well: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4636004 Live test errors are pre-existing on main |
maorleger
requested review from
a team,
KarishmaGhiya,
benbp,
ckairen,
mikeharder,
minhanh-phan,
schaabs,
timovv and
weshaggard
as code owners
Contributor
There was a problem hiding this comment.
PR Overview
This PR adds support for the PersistOidcToken parameter across various pipeline templates and test configurations for live tests. The key changes include:
- Adding a new PersistOidcToken boolean parameter in multiple pipeline templates.
- Propagating the PersistOidcToken parameter into job definitions.
- Updating test configurations in the SDK packages to leverage the new parameter.
Reviewed Changes
| File | Description |
|---|---|
| eng/pipelines/templates/stages/archetype-sdk-tests.yml | Added PersistOidcToken parameter and passed it to the extended stage settings |
| eng/pipelines/templates/stages/archetype-sdk-tests-isolated.yml | Added PersistOidcToken parameter and passed it along for isolated test stages |
| eng/pipelines/templates/jobs/live.tests.yml | Defined PersistOidcToken as a parameter and injected it into job configurations |
| sdk/identity/identity/tests.yml | Removed the inline script that set OIDC variables and replaced it with PersistOidcToken set to true |
| sdk/keyvault/keyvault-admin/tests.yml | Added PersistOidcToken set to true in the test configuration |
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
sdk/identity/identity/tests.yml:10
- The inline script setting OIDC variables has been removed in favor of using PersistOidcToken. Please verify that the new mechanism correctly establishes and propagates the OIDC environment variables, ensuring no regression in test behavior.
PersistOidcToken: true
eng/pipelines/templates/jobs/live.tests.yml:48
- There is an inconsistency where the live.tests pipeline defaults PersistOidcToken to false, yet tests in SDK configurations override it to true. Please ensure that the intended behavior is consistent across environments.
- name: PersistOidcToken
benbp
approved these changes
Mar 10, 2025
maorleger
force-pushed
the
persist-oidc-token
branch
from
3782227 to
f38774d
Compare
timovv
approved these changes
Mar 10, 2025
KarishmaGhiya
approved these changes
Mar 10, 2025
github-project-automation
bot
moved this from Untriaged
to In Progress
in Azure Identity SDK Improvements
github-project-automation
bot
moved this from In Progress
to Done
in Azure Identity SDK Improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/identity@azure/keyvault-admin@azure/keyvault-keysIssues associated with this PR
Describe the problem that is addressed by this PR
Builds on previous work in #31335
This PR adds support for
PersistOidcTokenparameter passing, allowing one torefresh their credential using
Connect-AzAccountoraz login