Skip to content

feat(playwrighttesting): separate api, test data processing and utility layers #46681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sid200026 merged 19 commits into from
Oct 21, 2024
Merged

feat(playwrighttesting): separate api, test data processing and utility layers #46681

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
7345746
feat(playwrighttesting): separate api, data processing and utility la…
Sid200026 Oct 16, 2024
1d5a12f
chore(): additional scalable run failure handling
Sid200026 Oct 16, 2024
f64347a
chore(): api retries and logging
Sid200026 Oct 16, 2024
ea1a3f1
chore(): reporting api failure error handling
Sid200026 Oct 16, 2024
4eff9d8
fix(): no access token error message logged with error level
Sid200026 Oct 17, 2024
ca57afc
chore(): remove null check condition in console writer
Sid200026 Oct 17, 2024
00e6f59
chore(): add different logging levels
Sid200026 Oct 17, 2024
3a92c39
refactor(): rename logger to microsoft-playwright-testing
Sid200026 Oct 17, 2024
cf88569
Update TestProcessor.cs
kashish2508 Oct 17, 2024
9bb7771
Update ReporterUtils.cs
kashish2508 Oct 17, 2024
094014d
Create ReporterUtilsTests.cs
kashish2508 Oct 17, 2024
51fe587
fix(): uri escape data string for workspace and run id
Sid200026 Oct 17, 2024
6cdba5a
fix(): ad hoc fixes
Sid200026 Oct 17, 2024
cc202fa
fix(): handle null sas uri post refresh
Sid200026 Oct 17, 2024
8a40eb6
chore(): change reporting api version 2024-09-01-preview
Sid200026 Oct 18, 2024
dde053b
chore(): add tests for reporter
Sid200026 Oct 18, 2024
b462813
chore(): add new api info
Sid200026 Oct 20, 2024
e96d865
fix(): remove parallelization from entra tests
Sid200026 Oct 20, 2024
8e548fd
Merge branch 'main' of https://github.com/Sid200026/azure-sdk-for-net…
Sid200026 Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update TestProcessor.cs
  • Loading branch information
@kashish2508
kashish2508 authored Oct 17, 2024
commit cf885696d767e145ec6735facd3faecbc2130ca9
15 changes: 12 additions & 3 deletions ...ting/Azure.Developer.MicrosoftPlaywrightTesting.TestLogger/src/Processor/TestProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
using Azure.Developer.MicrosoftPlaywrightTesting.TestLogger.Implementation;
using Azure.Developer.MicrosoftPlaywrightTesting.TestLogger.Interface;
using Azure.Developer.MicrosoftPlaywrightTesting.TestLogger.Model;
using Azure.Developer.MicrosoftPlaywrightTesting.TestLogger.Utility;
using Azure.Storage.Blobs;
using Microsoft.VisualStudio.TestPlatform.ObjectModel;
using Microsoft.VisualStudio.TestPlatform.ObjectModel.Client;
Expand Down Expand Up @@ -152,21 +153,29 @@ public void TestRunCompleteHandler(object? sender, TestRunCompleteEventArgs e)
{
if (RawTestResultsMap.TryGetValue(testResult.TestExecutionId!, out RawTestResult? rawResult) && rawResult != null)
{
// Renew the SAS URI if needed
var reporterUtils = new ReporterUtils();
if (sasUri == null || !reporterUtils.IsTimeGreaterThanCurrentPlus10Minutes(sasUri.Uri))
{
sasUri = _serviceClient.GetTestRunResultsUri(); // Create new SAS URI
_logger.Info($"Fetched SAS URI with validity: {sasUri?.ExpiresAt} and access: {sasUri?.AccessLevel}.");
}

// Upload rawResult to blob storage using sasUri
var rawTestResultJson = JsonSerializer.Serialize(rawResult);
var filePath = $"{testResult.TestExecutionId}/rawTestResult.json";
UploadBuffer(sasUri!.Uri!, rawTestResultJson, filePath);
}
else
{
_logger.Info("Couldnt find rawResult for Id: " + testResult.TestExecutionId);
_logger.Info("Couldn't find rawResult for Id: " + testResult.TestExecutionId);
}
}
_logger.Info("Successfully uploaded raw test results");
}
else
{
_logger.Error("Sas Uri is empty");
_logger.Error("SAS URI is empty");
}
}
catch (Exception ex)
Expand All @@ -177,7 +186,7 @@ public void TestRunCompleteHandler(object? sender, TestRunCompleteEventArgs e)
EndTestRun(e);
}

#region Test Processor Helper Methods
#region Test Processor Helper Methods
private void EndTestRun(TestRunCompleteEventArgs e)
{
if (_cloudRunMetadata.EnableResultPublish && !FatalTestExecution)
Expand Down