[databoxedge] SDK validation for TSP #53424
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
HarveyLink
requested review from
ArcturusZhang and
ArthurMa1978
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Azure.ResourceManager.DataBoxEdge SDK to align with a new version of the Azure REST API specification. The changes include updates to reference a new API spec commit, modifications to OpenAPI file references, and additions of new properties to support enhanced functionality.
Key changes:
- Updated API specification reference to a newer commit hash
- Renamed API definition file references from
databoxedge.jsontoopenapi.json - Added new properties:
KubernetesWorkloadProfiletoDataBoxEdgeDeviceData,IPRangetoDataBoxEdgeLoadBalancerConfig, and setter forFolderproperty inDataBoxEdgeJobData - Made
DataBoxEdgeJobDataconstructor public and introduced backward-compatible method overloads withEditorBrowsableattributes
Reviewed Changes
Copilot reviewed 3 out of 120 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/databoxedge/Azure.ResourceManager.DataBoxEdge/src/autorest.md | Updated API spec reference and corrected OpenAPI file references |
| sdk/databoxedge/Azure.ResourceManager.DataBoxEdge/api/Azure.ResourceManager.DataBoxEdge.netstandard2.0.cs | Added new properties and backward-compatible factory method overloads |
| sdk/databoxedge/Azure.ResourceManager.DataBoxEdge/api/Azure.ResourceManager.DataBoxEdge.net8.0.cs | Added new properties and backward-compatible factory method overloads (mirroring netstandard2.0 changes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TSP PR: Azure/azure-rest-api-specs#37236
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.