Update AOT pipeline to no longer require ci parameters #53752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-redding
changed the title
m-redding
changed the title
weshaggard
reviewed
Nov 10, 2025
weshaggard
reviewed
Nov 10, 2025
| } | ||
| Write-Host "Running Check-AOT-Compatibility.ps1 for Package: $($package.ArtifactName) Service $($package.ServiceDirectory)" | ||
|
|
||
| $scriptPath = Join-Path $PSScriptRoot "Check-AOT-Compatibility.ps1" |
Member
There was a problem hiding this comment.
This is a place we should consider switching to call the azsdk cli command instead of calling the script directly.
weshaggard
reviewed
Nov 10, 2025
weshaggard
reviewed
Nov 10, 2025
weshaggard
reviewed
Nov 10, 2025
eng/service.proj
Outdated
| <WriteLinesToFile File="$(OutputProjectFilePath)" Lines="@(_WriteToLines)" /> | ||
| </Target> | ||
|
|
||
| <Target Name="GetAotCompatOptOut"> |
Member
There was a problem hiding this comment.
See my other comment but this shouldn't be needed. We probably should clean-up the other similar cases now as well.
weshaggard
reviewed
Nov 10, 2025
m-redding
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.