Skip to content

Update AOT pipeline to no longer require ci parameters #53752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
m-redding wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Update AOT pipeline to no longer require ci parameters #53752

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
151ff61
first pass on updating AOT CI
m-redding Nov 7, 2025
78017be
clean up repo refs in ci files
m-redding Nov 7, 2025
caa1dcf
more yml updates
m-redding Nov 7, 2025
daf1963
script updates
m-redding Nov 7, 2025
32d9e29
fix script
m-redding Nov 7, 2025
0e0efe6
more updates
m-redding Nov 7, 2025
dcb0dde
try fixing yaml
m-redding Nov 7, 2025
374e8ca
debugging
m-redding Nov 7, 2025
81b5474
Merge branch 'main' into aot-revamp
m-redding Nov 17, 2025
729dbe0
initial feedback
m-redding Nov 18, 2025
86cf99f
update parameter
m-redding Nov 18, 2025
2dcfbc0
Merge branch 'main' into aot-revamp
m-redding Dec 10, 2025
60977ae
attempt to delete PR script
m-redding Dec 10, 2025
4c66b19
another clean up
m-redding Dec 10, 2025
d54c3e1
fix attempt
m-redding Dec 10, 2025
1d8a3f3
another attempt
m-redding Dec 10, 2025
e7ab6bc
another attempt
m-redding Dec 10, 2025
238ca76
debugging statement
m-redding Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
debugging
  • Loading branch information
@m-redding
m-redding committed Nov 7, 2025
commit 374e8cab8a0fea459a324d37599f5de7911a2e51
7 changes: 5 additions & 2 deletions eng/scripts/compatibility/Check-AOT-Compatibility-For-PR.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,12 @@ $failedAotChecks = $false
foreach ($package in $filteredPackages) {
Write-Host "Running Check-AOT-Compatibility.ps1 for Package: $($package.ArtifactName) Service $($package.ServiceDirectory)"

& $PSScriptRoot/Check-AOT-Compatibility.ps1 `
-PackageName $package.ArtifactName `
$scriptPath = Join-Path $PSScriptRoot "Check-AOT-Compatibility.ps1"
Copy link
Member

@weshaggard weshaggard Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a place we should consider switching to call the azsdk cli command instead of calling the script directly.

Write-Host "Calling: $scriptPath -ServiceDirectory $($package.ServiceDirectory) -PackageName $($package.ArtifactName)"

& $scriptPath `
-ServiceDirectory $package.ServiceDirectory `
-PackageName $package.ArtifactName

if ($LASTEXITCODE -ne 0) {
$failedAotChecks = $true
Expand Down
Loading