Skip to content

Fix MPG generator to emit model factory methods for models with flattened read-only properties #54447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Fix MPG generator to emit model factory methods for models with flattened read-only properties #54447

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
777d053
Initial plan
Copilot Dec 11, 2025
3bb9792
Fix MPG generator to defer model factory type filtering until after f…
Copilot Dec 11, 2025
4d0cbc2
Address code review feedback - simplify ModelFactoryVisitor
Copilot Dec 11, 2025
bc04ea7
Improve logic to handle multiple ModelFactoryProvider instances
Copilot Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address code review feedback - simplify ModelFactoryVisitor 
Co-authored-by: live1206 <[email protected]>
  • Loading branch information
@live1206
Copilot and live1206 committed Dec 11, 2025
commit 4d0cbc2ae7e4e660738b45987643c85cc8681a0f
17 changes: 3 additions & 14 deletions ...ient-csharp-mgmt/generator/Azure.Generator.Management/src/Visitors/ModelFactoryVisitor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,30 +18,19 @@ internal class ModelFactoryVisitor : ScmLibraryVisitor
{ "ETag", "etag" }
};

private ModelFactoryProvider? _modelFactory;
private bool _modelTypesEnsured = false;

protected override TypeProvider? VisitType(TypeProvider type)
{
if (type is ModelFactoryProvider modelFactory)
{
// Store the model factory for post-processing
_modelFactory = modelFactory;
}
return base.VisitType(type);
}

protected override TypeProvider? PostVisitType(TypeProvider type)
{
// Process model factory after all models have been visited
if (type is ModelFactoryProvider && _modelFactory != null && !_modelTypesEnsured)
if (type is ModelFactoryProvider modelFactory && !_modelTypesEnsured)
{
// Ensure model types are built now that all flattening is complete
ManagementClientGenerator.Instance.OutputLibrary.EnsureModelTypesBuilt();
_modelTypesEnsured = true;

var updatedMethods = new List<MethodProvider>();
foreach (var method in _modelFactory.Methods)
foreach (var method in modelFactory.Methods)
{
var returnType = method.Signature.ReturnType;
if (returnType is not null && ManagementClientGenerator.Instance.OutputLibrary.IsModelFactoryModelType(returnType))
Expand All @@ -56,7 +45,7 @@ internal class ModelFactoryVisitor : ScmLibraryVisitor
updatedMethods.Add(method);
}
}
_modelFactory.Update(methods: updatedMethods);
modelFactory.Update(methods: updatedMethods);
}

return base.PostVisitType(type);
Expand Down
Loading