Deprioritize CODEOWNERS EngSys ownership + fix one invalid path
#28534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konrad-jamrozik
added
the
Central-EngSys
konrad-jamrozik
requested review from
jsquire and
ronniegeraghty
as code owners
benbp
approved these changes
Jan 31, 2023
weshaggard
reviewed
Feb 1, 2023
konrad-jamrozik
pushed a commit
to Azure/azure-sdk-for-go
that referenced
this pull request
Feb 10, 2023
As part of ongoing work of enabling wildcard support for `CODEOWNERS`: - Azure/azure-sdk-tools#2770 - Azure/azure-sdk-tools#5088 and enabling stricter validation: - Azure/azure-sdk-tools#4859 this PR: - fixes invalid paths, to match rules explained [here](https://github.com/Azure/azure-sdk/blob/main/docs/policies/opensource.md#codeowners); - removes `/**/tests.yml` and `/**/ci.yml`, to avoid all build failure notifications being routed to it once we enable the new regex-based, wildcard-supporting `CODEOWNERS` matcher, per: Azure/azure-sdk-tools#5088 (comment) Once this PR is merged, I will enable the new `CODEOWNERS` matcher, similar to how it was done for `net` repo by these two PRs: - Azure/azure-sdk-tools#5241 - Azure/azure-sdk-tools#5240 Related PRs: - Similar PR fixing invalid paths, but for `net` repo: Azure/azure-sdk-for-net#33584 - Similar PR deprioritizing the Azure SDK EngSys team ownership, but for `python` repo: Azure/azure-sdk-for-python#28534
konrad-jamrozik
pushed a commit
to Azure/azure-sdk-for-go
that referenced
this pull request
Feb 13, 2023
* Update `CODEOWNERS` paths: fix invalid paths As part of ongoing work of enabling wildcard support for `CODEOWNERS`: - Azure/azure-sdk-tools#2770 - Azure/azure-sdk-tools#5088 and enabling stricter validation: - Azure/azure-sdk-tools#4859 this PR: - fixes invalid paths, to match rules explained [here](https://github.com/Azure/azure-sdk/blob/main/docs/policies/opensource.md#codeowners); - removes `/**/tests.yml` and `/**/ci.yml`, to avoid all build failure notifications being routed to it once we enable the new regex-based, wildcard-supporting `CODEOWNERS` matcher, per: Azure/azure-sdk-tools#5088 (comment) Once this PR is merged, I will enable the new `CODEOWNERS` matcher, similar to how it was done for `net` repo by these two PRs: - Azure/azure-sdk-tools#5241 - Azure/azure-sdk-tools#5240 Related PRs: - Similar PR fixing invalid paths, but for `net` repo: Azure/azure-sdk-for-net#33584 - Similar PR deprioritizing the Azure SDK EngSys team ownership, but for `python` repo: Azure/azure-sdk-for-python#28534 * Update .github/CODEOWNERS Co-authored-by: Ben Broderick Phillips <[email protected]> --------- Co-authored-by: Ben Broderick Phillips <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of ongoing work of enabling wildcard support for
CODEOWNERS:and enabling stricter validation:
this PR deprioritizes ownership rules for Azure SDK Engineering System team, to avoid all build failure notifications being routed to it once we enable the new regex-based, wildcard-supporting
CODEOWNERSmatcher, per:As a consequence of this PR, possibly the automatically assigned PR reviewers will change for some paths. The full list of of such changes can be determined by running relevant test provided by this PR:
CODEOWNERSmatcher on all remaining repositories in scope. azure-sdk-tools#5266I provided a table with build failure notification recipients changes here. You can also reach out to me to get that information.
Once this PR is merged, I will enable the new
CODEOWNERSmatcher, similar to how it was done fornetrepo by these two PRs:azure-sdk-for-netrepo azure-sdk-tools#5241NotificationConfigurationpackage from20230119.1to20230127.4azure-sdk-tools#5240Doing so will also change to whom build failure notification emails are sent.
Related PRs:
CODEOWNERS: Fix paths in CODEOWNERS #28504netrepo: Remove CODEOWNERS rules/**/ci.ymland/**/tests.ymlazure-sdk-for-net#33595Secondary change
This PR also fixes path
sdk/graphrbac/to be/sdk/graphrbac/. This path was missed by: