Fix paths in CODEOWNERS #28504
Merged
Fix paths in CODEOWNERS #28504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konrad-jamrozik
added
the
Central-EngSys
konrad-jamrozik
requested review from
jsquire and
ronniegeraghty
as code owners
konrad-jamrozik
commented
Jan 27, 2023
konrad-jamrozik
force-pushed
the
users/kojamroz/make_co_valid
branch
3 times, most recently
from
d2c3fcd to
7911056
Compare
konrad-jamrozik
force-pushed
the
users/kojamroz/make_co_valid
branch
from
7911056 to
1f368dc
Compare
jsquire
approved these changes
Jan 27, 2023
weshaggard
approved these changes
Jan 27, 2023
Member
weshaggard
left a comment
weshaggard
left a comment
There was a problem hiding this comment.
Looks good. I assume you plan to remove the **/ci.yml patterns in another change.
This was referenced Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes paths in CODEOWNERS that were violating following two rules, given here:
//These changes should have no effect on owners determination by GitHub.
Violations of rule 2. would result in ADO build failure notifications being set to different set of people once we enable the new regex-based CODEOWNERS matcher, per:
This PR is done in preparation of following work:
This PR is analogous to its equivalent for
azure-sdk-for-netrepo:I obtained the data required to make this PR by running tools added in this PR:
CODEOWNERSpaths that are missing suffix slash; add support for diffing toCODEOWNERSversion with some paths removed; add tools for analyzing azure-sdk-for-pythonCODEOWNERS. azure-sdk-tools#5245